Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even item splitting breaks on left click drag when "LMBTweakWithitem" is enabled. #42

Closed
1 task done
PlayfulPiano opened this issue Jan 12, 2025 · 9 comments
Closed
1 task done

Comments

@PlayfulPiano
Copy link

Your GTNH Discord Username

PlayfulPiano

Mod Version

1.2.12 pre

Bug Report

https://www.twitch.tv/playfulpiano/clip/LightAbrasiveBeeKevinTurtle-q9Hkazm6ZEYpWZN0

Bug comes from MouseTweaks (issue occurs with the mod pre-bogo for reference). Disabling it fixes the issue.

Might be worth either making this setting default false for the time being.

Java Version

Java 21

Mod List or GTNH Pack Version

GTNH 2.7.2

Final Checklist

  • I have searched the issues and haven't found a similar issue.
@chochem
Copy link
Member

chochem commented Jan 12, 2025

not again XD GTNewHorizons/GT-New-Horizons-Modpack#16145

if bogosorter doesnt use the old configs then you need to generate a new one and transfer all the settings as well in the config repo.

@PlayfulPiano
Copy link
Author

not again XD GTNewHorizons/GT-New-Horizons-Modpack#16145

if bogosorter doesnt use the old configs then you need to generate a new one and transfer all the settings as well in the config repo.

yeah, maybe it would be good to make sure that bogo can recognize the older mousetweaks config file when it properly gets added to stable so ppl don't have to redo their configs on swap.

@chochem
Copy link
Member

chochem commented Jan 12, 2025

people always have to do swap their configs that is not optional.

just checked the config, it is in fact still turned off. so it is actually working correctly?

changing the default is fair though, or better yet potentially: deleting the whole thing

@PlayfulPiano
Copy link
Author

people always have to do swap their configs that is not optional.

just checked the config, it is in fact still turned off. so it is actually working correctly?

changing the default is fair though, or better yet potentially: deleting the whole thing

No I mean how bogosorter replaces the old mousetweaks.cfg with a new file and doesn't recognize it when swapping mods

standalone mousetweaks config pre-bogo
image

post-bogo mousetweaks config (I made modifications to fix the issue but previously it was using default config settings)
image

basically when I swapped over from mousetweaks to bogo, the old mousetweaks config file got replaced when bogo was loaded rather than just reading that config file as is

@chochem
Copy link
Member

chochem commented Jan 12, 2025

that was done here GTNewHorizons/GT-New-Horizons-Modpack#18685

@chochem
Copy link
Member

chochem commented Jan 12, 2025

default config settings might be broken though

@PlayfulPiano
Copy link
Author

ah ic, and yeah if it's meant to be false by default then it seems defaults are broken

@0hwx
Copy link
Collaborator

0hwx commented Jan 13, 2025

ah ic, and yeah if it's meant to be false by default then it seems defaults are broken

The default was taken from the old MouseTweaks config.

How about adding a delay before the LMB tweak is activated with an item (e.g., 1 or 2 seconds)?

0hwx added a commit that referenced this issue Jan 17, 2025
@0hwx
Copy link
Collaborator

0hwx commented Jan 17, 2025

Should be fixed in (#50)

@0hwx 0hwx closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants