Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alpha_complex] new do_sqrt argument #80

Open
mglisse opened this issue Jul 10, 2019 · 0 comments · May be fixed by #1138
Open

[Alpha_complex] new do_sqrt argument #80

mglisse opened this issue Jul 10, 2019 · 0 comments · May be fixed by #1138
Labels
enhancement New feature or request

Comments

@mglisse
Copy link
Member

mglisse commented Jul 10, 2019

The filtration values we use in the alpha complex are squared radii. Most applications are more interested in a (non-squared) radius. We use squares because if we add weights, taking the square root becomes less meaningful, in particular if the value becomes negative. But I think we should make it as easy as possible for people to get the square root they expect, and a parameter seems to be the easiest, passing do_sqrt=True if we want the square root. The name do_sqrt is just a placeholder for the report, better names are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant