From 386e5d285ea3a543f8eb0f86cc3b7c08193ba160 Mon Sep 17 00:00:00 2001 From: Eric Mehl Date: Fri, 11 Oct 2024 17:20:04 -0400 Subject: [PATCH] InteractiveRenderTest : `testAddLight` tolerance It seems that the change in #6061 to use Cycles' blue noise sampling pattern increased the time it takes for the render to resolve, causing intermittent test failures. Increasing the error tolerance gets the tests passing again without increasing the wait time for pixels. --- python/GafferSceneTest/InteractiveRenderTest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/GafferSceneTest/InteractiveRenderTest.py b/python/GafferSceneTest/InteractiveRenderTest.py index 424204604b..0f21756684 100644 --- a/python/GafferSceneTest/InteractiveRenderTest.py +++ b/python/GafferSceneTest/InteractiveRenderTest.py @@ -1097,7 +1097,7 @@ def testAddLight( self ) : c = self._color3fAtUV( s["catalogue"], imath.V2f( 0.5 ) ) # Tolerance is high due to sampling noise in Cycles, but is more than sufficient to # be sure that the new light has been added (otherwise there would be no green at all). - self.assertTrue( ( c / c[0] ).equalWithAbsError( imath.Color3f( 1, 1, 0 ), 0.2 ) ) + self.assertTrue( ( c / c[0] ).equalWithAbsError( imath.Color3f( 1, 1, 0 ), 0.25 ) ) s["r"]["state"].setValue( s["r"].State.Stopped )