GafferModule : Windows verifyAllocator()
#6087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Oct 15, 2024
src/GafferModule/GafferModule.cpp
Outdated
Comment on lines
205
to
209
| IECore::msg( IECore::Msg::Debug, "Gaffer", "Failed to install TBB memory allocator. Performance may be degraded." ); | ||
| for( char **logEntry = replacementLog; *logEntry != 0; logEntry++ ) | ||
| { | ||
| IECore::msg( IECore::Msg::Info, "Gaffer", *logEntry ); | ||
| } |
There was a problem hiding this comment.
Seems a bit odd that the primary message ("Failed to install") is given a lower log level than the detailed messages. Perhaps WARNING for the first, and DEBUG for the others, or even warning for all? Now I think about it, it does seem worth having whatever we print be visible at the default logging level, since we definitely don't expect or want this to fail.
There was a problem hiding this comment.
Agreed, more visibility if it fails does sound good. I changed it to WARNING in 1edd800 and squashed down.
ericmehl
force-pushed
the
windowsAllocator
branch
from
bc8fb75
to
1edd800
Compare
|
Thanks John! I did a rebase and squash after changing the log level to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check on Windows when starting Gaffer to verify that the TBB allocator has been installed correctly. Other platforms don't perform the check and the check method is not present.
I don't actually know what circumstances the allocator would fail to install itself. If I just remove the
tbbmalloc_proxy.dllfile from the installation, Gaffer immediately and silently fails to open at all.But I think this is still worthwhile as an easy box to check off when debugging performance problems.
Checklist