Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to pyproject.toml #113

Merged
merged 3 commits into from
Sep 5, 2024
Merged

chore: move to pyproject.toml #113

merged 3 commits into from
Sep 5, 2024

Conversation

beckermr
Copy link
Collaborator

@beckermr beckermr commented Sep 5, 2024

This PR moves the code to use pyproject.toml.

Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #113 will degrade performances by 37.1%

Comparing pyproject (ac501a5) with main (d99de81)

Summary

❌ 1 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main pyproject Change
test_benchmarks_lanczos_interp[kval-no_conserve_dc-run] 343.4 µs 546 µs -37.1%

@beckermr beckermr marked this pull request as ready for review September 5, 2024 17:55
@ismael-mendoza ismael-mendoza self-requested a review September 5, 2024 21:54
Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beckermr beckermr merged commit e43167f into main Sep 5, 2024
7 checks passed
@beckermr beckermr deleted the pyproject branch September 5, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants