Change all the run to runOnce
#90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rakrakon
commented
Nov 20, 2024
rakrakon
commented
- Convert everything to runOnce
- Convert everything to runOnce
- Add waitUntil in climb
- Rebase conflicts
- Rebase conflicts
…rruns # Conflicts: # src/main/kotlin/frc/robot/subsystems/climb/Climb.kt # src/main/kotlin/frc/robot/subsystems/conveyor/Conveyor.kt # src/main/kotlin/frc/robot/subsystems/hood/Hood.kt # src/main/kotlin/frc/robot/subsystems/shooter/Shooter.kt
katzuv
reviewed
Nov 20, 2024
| @@ -107,7 +107,7 @@ object RobotContainer { | |||
| driverController().back() | |||
| .whileTrue(gripper.setRollerPower(0.4)) | |||
| .onFalse(gripper.stop()) | |||
| driverController().start().whileTrue(intake.reset()) | |||
| driverController().start().whileTrue(intake.reset()).onFalse(intake.finishReset()) | |||
There was a problem hiding this comment.
Instead, intake.reset() can use runEnd() decorator.
There was a problem hiding this comment.
I'm not really sure what is the decorator you're referring to.
Also i think it doesn't matter that much.
There was a problem hiding this comment.
I'm not really sure what is the decorator you're referring to.
How lucky we are to have an API reference 🙃.
I think it's nice because otherwise you duplicate code, and this logic IMO should be in the subsystem.
There was a problem hiding this comment.
You mean a runend command? Otherwise I'm not really sure what you're referring to exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.