Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some classes #1

Open
magro opened this issue Dec 24, 2014 · 2 comments
Open

Rename some classes #1

magro opened this issue Dec 24, 2014 · 2 comments

Comments

@magro
Copy link
Contributor

magro commented Dec 24, 2014

DirectLinkRelationType -> DirectLinkRelation (the same for template)
JsonHomeService -> JsonHomeClient
@magro
Copy link
Contributor Author

magro commented Dec 24, 2014

Re link relation vs link relation type: the json home spec and rfc 5988 (http://tools.ietf.org/html/rfc5988) use "link relation type", and "link relation" only sometimes as a short form. Therefore DirectLinkRelationType is more correct, renaming it to DirectLinkRelation would just make it more compact. Alternatively DirectLinkRelType could be used.

@magro
Copy link
Contributor Author

magro commented Dec 24, 2014

Re JsonHomeService -> JsonHomeClient: There's already the JsonHomeClient which is used for loading a json home doc, this would have to be renamed as well (to loader, fetcher,...?).

@magro magro mentioned this issue Dec 29, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magro