Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 01_example_project.md for kedro 0.19 #527

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

noklam
Copy link

@noklam noklam commented Feb 21, 2024

Description

Why was this PR created?
I am working through the tutorial and see something that need to be updated with 0.19.

Changes:

  • Use the kedro new shortcut

Development notes

What have you changed, and how has this been tested?

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@noklam noklam marked this pull request as draft February 21, 2024 17:42
@Galileo-Galilei
Copy link
Owner

Thanks @noklam. Honestly I think there much more to do since this starter has been archived (https://github.com/kedro-org/kedro-starters/tree/main/pandas-iris) and I should update the whole documentation (see #503), but I can merge it if you confirm the install currently fails which is a very bad developer experience.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc3b7bf) 99.90% compared to head (40161d0) 99.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          29       29           
  Lines        1008     1008           
=======================================
  Hits         1007     1007           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noklam
Copy link
Author

noklam commented Feb 22, 2024

Yes, I can confirm this is failing since the starter is removed. I tried kedro new --starter pandas-iris --checkout 0.18.14, which also fails. It should work but there is some checking in kedro preventing this.

I agree this is not a good experience. I am currently going through the tutorial so I have to modify the steps along the way too. I can try to map out the things that need to be updated, or i can include this into this PR and then you can take over if you want. Let me know what do you preferred.

If you are using pandas-iris before, spaceflights-pandas should be the closest one you can get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite tutorial in documentation with spaceflights-pandas
3 participants