Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saw-remote-api: Add --version command-line option #2237

Open
RyanGlScott opened this issue Feb 27, 2025 · 2 comments
Open

saw-remote-api: Add --version command-line option #2237

RyanGlScott opened this issue Feb 27, 2025 · 2 comments
Labels
subproject Issues involving one of the various subprojects SAW depends on subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings type: feature request Issues requesting a new feature or capability usability An issue that impedes efficient understanding and use

Comments

@RyanGlScott
Copy link
Contributor

Just as the saw binary features a --version command-line option, the saw-remote-api binary should also include a --version option. This would be especially useful for the saw-remote-api Docker image (which is distributed separately from the saw Docker image), where it is otherwise indirect to determine what version is being used.

See also GaloisInc/cryptol#1815.

@RyanGlScott RyanGlScott added subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings type: feature request Issues requesting a new feature or capability usability An issue that impedes efficient understanding and use labels Feb 27, 2025
@sauclovian-g
Copy link
Contributor

This turns out to be a headache because argo handles the command line, and while it lets the application add options to subcommands, it doesn't allow adding top-level options. So we can do saw-remote-api stdio --version relatively easy, but doing it properly requires API-breaking changes in argo.

Furthermore, the way the version information is generated in the build makes it only accessible to the saw executable. Getting it to saw-remote-api requires either a bunch of duplication or a bunch of reorganization, so we probably shouldn't try to get it into the immediately pending release.

@sauclovian-g
Copy link
Contributor

(See GaloisInc/argo#218 in argo.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subproject Issues involving one of the various subprojects SAW depends on subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings type: feature request Issues requesting a new feature or capability usability An issue that impedes efficient understanding and use
Projects
None yet
Development

No branches or pull requests

2 participants