Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] Export to MySQL #1

Open
TomLewis opened this issue Feb 15, 2017 · 8 comments
Open

[request] Export to MySQL #1

TomLewis opened this issue Feb 15, 2017 · 8 comments

Comments

@TomLewis
Copy link

I would love you.

JSON is great and all, buy MySQL gives us an insane amount of options, WebUI being my main thought, could create an awesome searchable web UI for items and shops, create statistics.
Massive brownie points if you can also push the Transaction.log to mysql, why they thought a flatfile would be a good idea is beyond me, mine is 166.55MB in size, this isnt very useful as a flatfile, MySQL on the other hand, I could search for amazing things, find trends, find issues, and again web UI :)

Pretty please!

@RoyCurtis
Copy link
Contributor

Thanks for your request! I make no promises in implementing this, tho it is an interesting idea. Some thoughts. . .

  • Do you have any ideas on how the seller data should export to MySQL? For example; should it use coordinates as the unique key/index? Should it log sign history (e.g. additions, removals)?
  • That said, what could you do with MySQL that couldn't be done with JSON? For example, a web UI is still possible; @LakenH created one that pulls the JSON data and processes it, on load time (source: https://github.com/LakenH/MCShop)
  • Good idea for transaction.log; I agree it's something that should be in a database rather than a log file. Although I could add this to SSE, eventually somebody should PR a change to SignShop to use MySQL instead

@TomLewis
Copy link
Author

TomLewis commented Mar 14, 2017

You know what, im going to use that JSON web UI, I was able to fork it and since its all entirely JS, I can host it inside Github pages, setup a sub-domain and im sure I can get SignShopExport to auto push json to github every X amount of time. I just want a nice looking statistics page, I will ask around my user base once my fork is live to see if anyone is any good with JS, my knowledge is non existent! That way is anyone wants to pull the same data and use it in their own application, they arnt hammering my server as itll be hosted on github!

The transaction log, I would very much appreciate still though :)

@RoyCurtis
Copy link
Contributor

Cool! Alright. Though if you are auto-pushing to GitHub (which you could do with crontab -e on linux, for example), I would personally limit it to one push per day.

Also, I noticed that you forked MCShop's master branch. Sorry for the confusion, but you may wish to fork/commit to the gamealition branch instead, as it is more up-to-date.

But otherwise yes, you could use the UI for statistics too! Good luck with finding a JS dev :D

Still keeping this request open for future use.

@TomLewis
Copy link
Author

Oh God dammit! How the hell do I fork that version? I click fork and it takes me to my already forked version...

@RoyCurtis
Copy link
Contributor

Actually, the fork already contains all branches (I forgot this, sorry), so you just need to switch to the gamealition branch locally and re-do your two commits on top.

I tried to do this myself, but your top-most commit will result in merge conflicts. It'll be easier just to re-do that commit by hand, I think. But here is a video of my attempt anyway.

@TomLewis
Copy link
Author

This is so confusing now, I, just going to delete everything and do it again. I managed to somehow pull the changes, but then when I tried to push my changes it was putting it in my own branch, and I don't want a branch I just want one repo, and I have no idea how to make that branch my main repo, which is needed to host on Github pages, this is so irritating.

@TomLewis
Copy link
Author

I have no idea how to use sourcetree to make a branch the main master... Why is this so difficult

@RoyCurtis
Copy link
Contributor

Do you have a Steam or Discord I could try to help via?

  • Discord: VanDerProtofsky#0468
  • Steam: VanDerProtofsky, but I will need to add you rather than vice versa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants