Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CoreLibs/object #13

Open
lyonbeckers opened this issue Dec 28, 2023 · 2 comments
Open

Implement CoreLibs/object #13

lyonbeckers opened this issue Dec 28, 2023 · 2 comments
Labels
unimplemented Playdate API An API from the Playdate SDK that hasn't been implemented in Playbit yet

Comments

@lyonbeckers
Copy link

I've been taking a look at implementing CoreLibs/object, as my game makes pretty heavy use of it. As far as I can see, there's nothing that's really specific to playdate in the CoreLibs implementation, aside from a couple places that use +=. I've replaced those two lines so that it'd work in Love, and just straight up copied it into playbit, and that seems to work, though I'm not really sure if that's what we'd want/are entitled to do given that the file is (c) Playdate, and there's this particular clause of the SDK License.

You will not:
...
- Use the SDK to develop applications for other platforms or to develop another SDK, without express written permission from Panic.

Though I'm not sure how it could really be reimplemented in any meaningful way that isn't just... rewording the existing CoreLibs implementation.

@gingerbeardman
Copy link

gingerbeardman commented Dec 28, 2023

I see object says: -- loosely based on http://replayism.com/code/barebones-lua-class/

That has disappeared but is in Wayback Machine https://web.archive.org/web/20150205023439/http://replayism.com/code/barebones-lua-class/

@SHiLLySiT
Copy link
Collaborator

@lyonbeckers I had emailed Panic about Playbit awhile back to see if I could take code from the SDK, but alas, they did not give me permission (and thus some loss of functionality after ee04a9d). So unfortunately we can't just copy CoreLibs/object with minor edits into Playbit, as it would violate the TOS as per the snippet you shared.

However as @gingerbeardman pointed out, we can start from the old blog post they found on Wayback Machine.

Also note: this is low priority for me right now since I don't use the object class in any of my projects, but I'd be happy to merge any PRs that implement it! 😄

@SHiLLySiT SHiLLySiT changed the title Implement object Implement CoreLibs/object Feb 15, 2024
@SHiLLySiT SHiLLySiT added the unimplemented Playdate API An API from the Playdate SDK that hasn't been implemented in Playbit yet label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unimplemented Playdate API An API from the Playdate SDK that hasn't been implemented in Playbit yet
Projects
None yet
Development

No branches or pull requests

3 participants