Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: linkedin/goavro
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: GannettDigital/linkedin_goavro
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Dec 7, 2024

  1. Accept "invalid" field names. 

    Some of our Avro schemas are generated with "invalid" names and this
library refuses to accept them.  That would be fine if it was only
on writing an Avro schema with such fields but it also refuses to
read any Avro schema, which is highly annoying.

See also #286
    @gannett-ggreer
    gannett-ggreer committed Dec 7, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    c3c535a View commit details
Showing with 2 additions and 1 deletion.
  1. +1 −1 go.mod
  2. +1 −0 name.go
2 changes: 1 addition & 1 deletion go.mod
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/linkedin/goavro/v2
module github.com/GannettDigital/linkedin_goavro/v2

go 1.12

1 change: 1 addition & 0 deletions name.go
View file
Original file line number Diff line number Diff line change
@@ -49,6 +49,7 @@ func checkString(s string) error {
if len(s) == 0 {
return errors.New("be non-empty string")
}
return nil // https://github.com/linkedin/goavro/issues/286
if strings.IndexFunc(s[:1], isRuneInvalidForFirstCharacter) != -1 {
return errors.New("start with [A-Za-z_]: " + s)
}