[QT] When viewing a transaction's details, the "From" field always says "unknown"

[jacobbaratta]

Describe the issue

In the QT client, when you double-click on a transaction or right click on it and select "show transaction details", a window appears with the transaction details in it. In this window, the "From" field always displays "unknown" instead of the expected source address(es) for the transaction.

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

1. Open garlicoin-qt
2. Navigate to the "Transactions" tab
3. Double-click on a transaction or right click on it and select "show transaction details"

Expected behaviour

The "From" field should display the source address(es) for the transaction (unless the transaction source is new coins, in which case it should either display something like "new coins" or "unknown").

Actual behaviour

The "From" field will display "unknown" instead of the expected source address(es).

Screenshots.

(for the above transaction, you can see in the explorer that the correct source address should be "GJ5ukdQRqVbVNftEYw4ZnRN5DxhBKdfEtZ", not "unknown")

What version of garlicoin-core are you using?

v0.16.0.2-0787900-dirty (64-bit) — Self compiled from GitHub source code.

Note: This bug was also observed on a pre-allium version of garlicoin-qt.

Machine specs:

• OS: OSX (macOS) 10.12.6
• CPU: i7-3770k
• RAM: 24 GB
• Disk size: 500 GB (OSX boot disk)
• Disk Type (HD/SDD): SSD (OSX boot disk)

Note: This is a Hackintosh, not a genuine Apple computer. I have not tested to see if this issue exists on genuine Apple computers or on other operating systems, but there is no reason to suspect that it would not be present on genuine Apple computers or on other operating systems, and therefore I decided not to test for this bug on other platforms.

Any extra information that might be useful in the debugging process.

N/A