-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Google Sheets and Github Configuration to be passed as a list of files/directories #47
base: main
Are you sure you want to change the base?
Conversation
Hi @jnormile @AidanNeeson ! This is a draft of the changes that allow you to take in a list of values for Google Sheets configuration as well as GitHub configuration. If you want to use a combination of directories and files and Sheets Config, you have to include the
You cannot put the flag once. Incorrect Command:
Another thing to note is that there is no validation being done on the input whatsoever. The only modification is to cast the string into a Keep in mind that depending on how you want to use the values in that list, you should:
Can I get you feedback on whether this approach in taking in the CLI values is acceptable or not? I'd like to know what you think before I continue with the remaining changes. Thanks! |
@noorbuchi , this implementation seems like it would work for our project to me! @AidanNeeson , do you see any problems I might be missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two thumbs up from me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
The most recent changes allow the SheetCollector infrastructure to take in a list of
I have to do something similar for the GitHub interactions. I'm hoping to get started on that soon as well. Please let me know what you think of the current implementation to far. |
@noorbuchi Our particular implementation doesn't require any of the GitHub interactivity--it's all purely on the Google Sheets side. So no rush at all on implementing the GitHub side of things. |
With these changes, you can now provide multiple values for Google Sheets and Github configurations. Here is an example of how it would work:
Note that the passed values are converted to
Path
object to facilitate checking if it exists and if it's a directory or a file.To get the example output, few changes were added to the default plugin to print the user provided CLI arguments.