Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

Modularizing the options html page #253

Open
GaurangTandon opened this issue Jun 4, 2019 · 5 comments
Open

Modularizing the options html page #253

GaurangTandon opened this issue Jun 4, 2019 · 5 comments
Assignees

Comments

@GaurangTandon
Copy link
Owner

The current options page is a complete mess. Addition/removal of any new configurable option requires going through different parts of the script(s) and manually changing them.

I would imagine an extensible system ("factory" maybe?) that generalizes a setting element, given the following:

  1. The UI for a setting, based on whether it is input, textarea, checkbox, etc. The factory should also have defaults.
  2. Have a default handler that updates the value in Data, as well as pre-functions for validation of user input and post-functions as callbacks after Data is updated.
  3. other minute details can be added I believe.
@ShivanshRakesh
Copy link

Hi. I see that this issue has been self-assigned, but I would be happy to help with the UI-Design part if its open for me.

@ShivanshRakesh
Copy link

A sample UI-Design modification I propose is to change this:

Screenshot from 2019-08-13 02-01-17

To this:

Screenshot from 2019-08-13 02-00-35

@GaurangTandon
Copy link
Owner Author

Thanks dude. But this is already being worked on by @jaidev123 and there's a big redesign coming up :)

@jaidevshriram
Copy link
Collaborator

Do checkout Prokeys-Frontend on my github and suggest anything you feel should be there!

@ShivanshRakesh
Copy link

Oh okay! I thought no one else was on it since it was self assigned. Nvm.
Sure @jaidev123 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants