Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcodes as external plugin #247

Open
dziudek opened this issue Jul 25, 2013 · 5 comments
Open

Shortcodes as external plugin #247

dziudek opened this issue Jul 25, 2013 · 5 comments
Assignees

Comments

@dziudek
Copy link
Contributor

dziudek commented Jul 25, 2013

No description provided.

@ghost ghost assigned dziudek Jul 25, 2013
@ckubs
Copy link

ckubs commented Mar 4, 2014

Even though everyone is doing it I don't see that a must as in the case of SEO stuff that you have to update and definetlly make a plugin, but it's ok I guess, to clean the theme a bit.

Now, I have one issue/question about shortcodes and wasn't necesary I think to open a new ticket.

This is a limitation of Wordpress itself or how shortcodes work? I'm using a charts plugin based on chart.js( this one http://wordpress.org/plugins/wp-charts/ ) and I can't put the chart shortcode inside a gavern shortcode( toggle, legend ...etc) because I only see the raw code.

Why do I want to do that? Donno if it's a plugin conflict with the theme CSS( or viceversa, the theme doesn't play nice with the plugin) but for example if I put the chart and the Gavern shortcode one next to the other( like Chart and under it a legend shortcode for eg. chart description), the Gavern shortcode overlaps the chart. :(

@dziudek
Copy link
Contributor Author

dziudek commented Mar 5, 2014

The problem is connected with fact that the shortcodes are not recursive. Teoretically you can put the content of the shortcode inside the do_shortcode function, but it can lead to the infinite loop.

@ckubs
Copy link

ckubs commented Mar 5, 2014

Thanks for your clarification, I understand now.
And about the thing from where I starded? Made a temporary wordpress Install and put inside some post a chart from that plugin and a gavern legend under it http://www.colle.ro/test2/?p=5

@dziudek
Copy link
Contributor Author

dziudek commented Mar 8, 2014

In order to put the legend under the chart, please add:

clear:both;

in the .gk-legend selector - it should solve your problem.

@ckubs
Copy link

ckubs commented Mar 8, 2014

Ok. That solved it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants