Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type of onTextChange event emitter #1032

Open
lukasmatta opened this issue Jul 11, 2022 · 0 comments · May be fixed by #1033
Open

Incorrect type of onTextChange event emitter #1032

lukasmatta opened this issue Jul 11, 2022 · 0 comments · May be fixed by #1033

Comments

@lukasmatta
Copy link

Hello,
currently onTextChange event emitter has generic type TagModel (which is superset of a string type) but string on its own would be sufficient. We only emit value of text input, which is always of string type.

ngx-chips/modules/components/tag-input/tag-input.ts

Line 270 in 8e34983

@Output() public onTextChange = new EventEmitter<TagModel>();

@lukasmatta lukasmatta linked a pull request Jul 11, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Set type of onTextChange to string lukasmatta/ngx-chips
1 participant
@lukasmatta