Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Skip buttons and some changes in comparisons cards #165

Open
3 of 5 tasks
Tracked by #134
MoeNick opened this issue Nov 27, 2024 · 3 comments
Open
3 of 5 tasks
Tracked by #134

Adding Skip buttons and some changes in comparisons cards #165

MoeNick opened this issue Nov 27, 2024 · 3 comments
Assignees
@HrithikSampson @maryjaf

Comments

@MoeNick
Copy link
Contributor

MoeNick commented Nov 27, 2024 •
edited by maryjaf
Loading

As a user, I want to skip the comparisons between 2 projects.
Image

Design:

https://www.figma.com/design/tP7Arb2C8aDB05wCVxVVSB/Pairwise-RF6--%3E-Voting-App?node-id=2961-78786&t=tnOSvUJNakyD19lA-4

Acceptance Criteria:

  • Lower bar has a new design in comparison flow.
  • Skip calls the algo to remain indifferent between 2 projects and only skip comparisons not stars
  • Undo and Skip button icons should change
  • Category label repositioned and adjusted alignments
  • COI button drop shadow has been removed
@MoeNick MoeNick mentioned this issue Nov 27, 2024
Open
5 tasks
@MoeNick MoeNick moved this to Draft Issues in Pairwise RF6 Nov 27, 2024
@MoeNick MoeNick changed the title Comparisons buttons with draw Adding Skip buttons and some changes in comparisons cards Dec 9, 2024
@MoeNick MoeNick moved this from Draft Issues to Todo in Pairwise RF6 Dec 9, 2024
@HrithikSampson HrithikSampson moved this from Todo to In Progress in Pairwise RF6 Dec 10, 2024
@HrithikSampson HrithikSampson self-assigned this Dec 10, 2024
@HrithikSampson HrithikSampson mentioned this issue Dec 12, 2024
Merged
@HrithikSampson
Copy link
Collaborator

this issue is ready to be tested

@HrithikSampson HrithikSampson moved this from In Progress to On Staging / QA in Pairwise RF6 Dec 26, 2024
@maryjaf
Copy link
Collaborator

maryjaf commented Dec 30, 2024 •
edited
Loading

  • Skip calls the algo to remain indifferent between 2 projects and only skip comparisons not stars
  • 1-
    @MoeNick said that tapping on "skip" should save the star, but now, when tapping on "skip," the project's star is not being saved

@HrithikSampson

@maryjaf maryjaf self-assigned this Dec 30, 2024
@maryjaf
Copy link
Collaborator

maryjaf commented Dec 31, 2024 •
edited
Loading

  • Category label repositioned and adjusted alignments
  • 2- this AC hasn't been passed and it isn't based on the design @HrithikSampson

image

design:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HrithikSampson HrithikSampson

@maryjaf maryjaf

Labels
None yet
Projects
Pairwise RF6
Status: On Staging / QA
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HrithikSampson @MoeNick @maryjaf