Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding close /ok to success attestation. #173

Open
2 tasks
Tracked by #134
MoeNick opened this issue Dec 9, 2024 · 9 comments
Open
2 tasks
Tracked by #134

adding close /ok to success attestation. #173

MoeNick opened this issue Dec 9, 2024 · 9 comments
Assignees

Comments

@MoeNick
Copy link
Contributor

MoeNick commented Dec 9, 2024

Image

  • Removing the cross icon
  • Adding OK button will lose and redirect user to categories page
@MoeNick MoeNick mentioned this issue Dec 9, 2024
5 tasks
@MoeNick MoeNick moved this to Draft Issues in Pairwise RF6 Dec 9, 2024
@MoeNick MoeNick moved this from Draft Issues to Todo in Pairwise RF6 Dec 9, 2024
@HrithikSampson HrithikSampson moved this from Todo to In Progress in Pairwise RF6 Dec 10, 2024
@HrithikSampson HrithikSampson self-assigned this Dec 10, 2024
@maryjaf maryjaf self-assigned this Dec 11, 2024
@maryjaf
Copy link
Collaborator

maryjaf commented Dec 15, 2024

I have one question about this issue, please take a look on current success attestation modal

budget:
Image

Category:
Image

This issue is only related to budget success donation modal and the update ballot on optimism button also should be removed?
@MoeNick

@maryjaf
Copy link
Collaborator

maryjaf commented Dec 16, 2024

This is the new design of budget success attestation modal with "OK" and "Update ballot on optimism" buttons and without cross icon
if this is approved I'll create a pull request

Screenshot 2024-12-16 at 11 13 01 AM

@MoeNick
Copy link
Contributor Author

MoeNick commented Dec 16, 2024

Hold on please I have to confirm it with @markoprljic first

@markoprljic
Copy link

@maryjaf Here you should have Update Ballot, View Transaction and Close in the same design as this modal.

@maryjaf
Copy link
Collaborator

maryjaf commented Dec 17, 2024

  • Removing the cross icon
  • Adding OK button will lose and redirect user to categories page

this is the design that we already have, so there is no need for adding OK button and only cross icon
should be removed,am I right ?

Screenshot 2024-12-17 at 11 18 08 AM

@MoeNick
Copy link
Contributor Author

MoeNick commented Dec 17, 2024

Yeah what has implemented is fine. Close should be with link.

@maryjaf
Copy link
Collaborator

maryjaf commented Dec 17, 2024

so we can close this issue? @MoeNick

@MoeNick
Copy link
Contributor Author

MoeNick commented Dec 17, 2024

As you said it only needs a removing of cross icon.

@HrithikSampson
Copy link
Collaborator

it is ready to be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

4 participants