-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintained Fork? #48
Comments
This fork seems like the way to go if @VincentJaouen is willing to maintain: |
Hey, sure I'll be happy to maintain the project |
@VincentJaouen are you able to push new releases of this gem to rubygems.org ? |
Yeah, at least updates are working with
UPD And with the following patch: module Pipedrive
class Base < OpenStruct
class << self
def all(response = nil, options={},get_absolutely_all=false)
res = response ? response.call(options) : get(resource_path, options)
if res.ok?
data = res['data'].nil? ? [] : res['data'].map{|obj| new(obj)}
pp data.map { |f| f.name }
if get_absolutely_all && res['additional_data']['pagination'] && res['additional_data']['pagination'] && res['additional_data']['pagination']['more_items_in_collection']
options[:query] = options[:query].merge({:start => res['additional_data']['pagination']['next_start']})
data += self.all(response,options,true)
end
data
else
bad_response(res,attrs)
end
end
end
end
class Deal < Base
def files(options = {}, get_absolutely_all=false)
File.all(->(options) { get("#{resource_path}/#{id}/files", options) }, options, get_absolutely_all)
end
end
end you can obtain all the files: Pipedrive::Deal.find(id).files({}, true) Although it's best to do something along the lines of what E.g.: module Pipedrive
class Deal < Base
def each_file
return to_enum(:each_file) unless block_given?
follow_pagination { |f| yield f }
end
def follow_pagination
options = {query: {start: 0, limit: 1}}
loop do
res = get("#{resource_path}/#{id}/files", options)
return bad_response(res) unless res.ok?
res['data'].each do |f|
yield File.new(f)
end
break unless res.dig('additional_data', 'pagination', 'more_items_in_collection')
options[:query][:start] = res.dig('additional_data', 'pagination', 'next_start')
end
end
end
end
Pipedrive::Deal.find(id).each_file do |f|
puts f.name
end bug at |
Hey this project has pretty clearly been abandoned by the owner based on the number of ignored Pull Requests for simple things like the now mandatory HTTPS endpoints. Does someone want to step up and declare their fork as an "official" descendant fork, with a promise to maintain it going forward (with help from the community, of course)?
The text was updated successfully, but these errors were encountered: