Classification test #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into classification_test
…into classification_test
bamarler
requested changes
Oct 29, 2025
Comment on lines
83
to
85
| response: EmbeddingResponse = await aembedding( | ||
| model=embed_model, input=inputs, dimensions=768 | ||
| ) |
Collaborator
There was a problem hiding this comment.
Try removing this dimensions parameter if you are having issues with forcing the BERT model's dimensions. I think it would be cool to get this working so give it another shot, if you run into more error send me a message.
Comment on lines
93
to
96
| classification_names: list[str] = await create_classifications_helper( | ||
| classification_service, | ||
| tenant_id, | ||
| [classification.name for classification in initial_classifications], |
Collaborator
There was a problem hiding this comment.
This was my bad before. I sent tenant_id to the method instead of extracted_files. You shouldn't need to change the signature of the method, just correct what is being sent through it.
Comment on lines
10
to
14
| async def create_classifications( | ||
| extracted_files: list[ExtractedFile], | ||
| classification_service: ClassificationService, | ||
| tenant_id: UUID, | ||
| initialClassifications: list[str], | ||
| ) -> list[str]: |
Collaborator
There was a problem hiding this comment.
Revert this change, if it properly sends the extracted files it should work properly
…ing and file mapping. Removed redundant second LLM call.
…tionary. Uncommented initialClassificatoins parameter which merges initial classifications with new ones.
bamarler
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished create_classifications.py and classify_files.py. Files connected and worth with frontend.