Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 chore: more configurable oauth settings #932

Closed
garrettladley opened this issue May 28, 2024 · 3 comments · Fixed by #936
Closed

🧹 chore: more configurable oauth settings #932

garrettladley opened this issue May 28, 2024 · 3 comments · Fixed by #936
Assignees
Labels
🧹 chore Not important but should be done soon

Comments

@garrettladley
Copy link
Member

garrettladley commented May 28, 2024

@alderwhiteford, should the redirect uri be hardcoded? what is it in reference to? frontend uri? backend uri?

RedirectURI: "http://localhost:3000",

@garrettladley garrettladley added the 🧹 chore Not important but should be done soon label May 28, 2024
@garrettladley
Copy link
Member Author

garrettladley commented May 28, 2024

@alderwhiteford
Copy link
Contributor

redirectURI is where the user is redirected to on the frontend after authenticating with the oauth client. It should be hardcoded for local and production

@garrettladley
Copy link
Member Author

but the port might not always be 3000? we might set to port 0 to get a dynamic port allocation

@garrettladley garrettladley linked a pull request May 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 chore Not important but should be done soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants