Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

term total nitrogen concentration (tot_nitro) is water specific, should be general #680

Open
mslarae13 opened this issue Oct 20, 2023 · 2 comments · May be fixed by #751
Open

term total nitrogen concentration (tot_nitro) is water specific, should be general #680

mslarae13 opened this issue Oct 20, 2023 · 2 comments · May be fixed by #751
Labels
1-TermUpdate Update suggestion for existing term, including bugs. Issues from "cig-bug" label moved here.

Comments

@mslarae13
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

The description of tot_nitro is : Total nitrogen concentration of water samples, calculated by: total nitrogen = total dissolved nitrogen + particulate nitrogen. Can also be measured without filtering, reported as nitrogen

The specification of water is limiting, you can have total N on all samples

this is used in extension

  • HydrocarbonResourcesCores
  • HydrocarbonResourcesFluidsSwabs
  • WastewaterSludge
  • Water

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://genomicsstandardsconsortium.github.io/mixs/0000102/

Expected behavior
A clear and concise description of what you expected to happen.

Terms definitions will be general, not environment specific and slot usage can be added for specific environments
@mslarae13 mslarae13 added the bug label Oct 20, 2023
@mslarae13
Copy link
Contributor Author

Actually, it looks like a separate slot was made to be less water specific... see https://genomicsstandardsconsortium.github.io/mixs/0000530/

I recommend deprecating tot_nitro and using tot_nitro_content

@ramonawalls ramonawalls added 1-TermUpdate Update suggestion for existing term, including bugs. Issues from "cig-bug" label moved here. and removed cig-bug labels Dec 28, 2023
@mslarae13 mslarae13 linked a pull request Jan 13, 2024 that will close this issue
deprecate tot_nitro slot #751
Draft
2 tasks
@cmungall cmungall removed a link to a pull request Apr 5, 2024
deprecate tot_nitro slot #751
Draft
2 tasks
@cmungall cmungall linked a pull request Apr 5, 2024 that will close this issue
Draft
2 tasks
@mslarae13 mslarae13 moved this to Todo in TWG Activity Track Jul 3, 2024
@mslarae13
Copy link
Contributor Author

will complete when deprecation protocol is in place

@mslarae13 mslarae13 moved this from Todo to For CIG in TWG Activity Track Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1-TermUpdate Update suggestion for existing term, including bugs. Issues from "cig-bug" label moved here.
Projects
TWG Activity Track
Status: Discuss
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deprecate tot_nitro slot GenomicsStandardsConsortium/mixs
2 participants
@ramonawalls @mslarae13