Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file drop convention is different from desktop geoda #1

Open
lanselin opened this issue Oct 23, 2024 · 7 comments
Open

file drop convention is different from desktop geoda #1

lanselin opened this issue Oct 23, 2024 · 7 comments
Labels
fix done fix done, please verify and close

Comments

@lanselin
Copy link

The file drop requires all four *.shp, *.shx, *.dbf and *.prj files for a "shape file" input. In desktop GeoDa, only the shp file needs to be dropped. That is a bit of an inconsistency. It would be better if specifying the shp file path also locates the associated files.

@lixun910
Copy link
Member

This can not be implemented in GeoDa.AI which is a browser app, because the browsers are designed with a sandboxed environment to keep web applications isolated from the local operating system and its file system.

Accessing files on a user’s device requires explicit permission or action, like drag-n-drop or file upload dialogs, from the user to ensure they are aware of which files are being accessed.

@lixun910 lixun910 added the wontfix This will not be worked on label Oct 28, 2024
@lanselin
Copy link
Author

Couldn't there be a way that when only a shp file is dropped, there is a dialog that asks if the remaining files, i.e., shx, dbf and prj can be added?

@lixun910
Copy link
Member

I think we can not do this as well. Because this will require the browser to access the e.g. dbf and shx files based on the path of dropped shp file. For security reason, the browser cannot access local files on local disk using local file path by default. One needs to select local file by either html upload input element or drag-n-drop. The file access must be used in response to user interactions, such as a button click, to ensure security.

@lanselin
Copy link
Author

lanselin commented Oct 28, 2024 via email

@lixun910
Copy link
Member

Yes, I agree. There is a warning the all files must be dropped, see the screenshot below. Maybe we need a better design to tell the user why and how.

Screenshot 2024-10-28 at 2 49 11 PM

@lixun910 lixun910 reopened this Oct 28, 2024
@lixun910
Copy link
Member

Btw, if we turn the https://geoda.ai into a native desktop app, there will be no such a restriction.

@lixun910 lixun910 removed the wontfix This will not be worked on label Oct 29, 2024
@lixun910
Copy link
Member

@lixun910 lixun910 reopened this Oct 29, 2024
@lixun910 lixun910 added the fix done fix done, please verify and close label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix done fix done, please verify and close
Projects
None yet
Development

No branches or pull requests

2 participants