Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log message to show centroid instead of envelope #9

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

patrickackermann
Copy link
Collaborator

@patrickackermann patrickackermann commented Jun 17, 2024

See: sogis/natgef-testbed#25

Log Message: IsInsideAreaByCode found an invalid overlap between code 'code_3' and 'code_4'. The offending geometry is near this point: POINT (2611301.395969979 1251933.7795835957)

Red is the offending geometry with the reported centroid:
image

Philippluca
Philippluca previously approved these changes Jun 17, 2024
Copy link
Member

@Philippluca Philippluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PP: Würde bei Envelope bleiben, da bei einem Halbmond der Punkt ausserhalb der Geometrie zu liegen kommt.

Co-authored-by: Philipp Lüthi <[email protected]>
@patrickackermann
Copy link
Collaborator Author

PP: Würde bei Envelope bleiben, da bei einem Halbmond der Punkt ausserhalb der Geometrie zu liegen kommt.

Oliver Jeker bevorzugt einen Punkt: sogis/natgef-testbed#25 (comment)

@patrickackermann patrickackermann merged commit 5f4d051 into main Jun 17, 2024
1 check passed
@patrickackermann patrickackermann deleted the change-log-message branch June 17, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants