-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify format for all sectors #217
Comments
@bgrundmann: feel free to add/update some ideas ;) |
I agree with all of these. To state the obvious right now none of these should touch Industry (because that would only cause merge failures). |
And now the changes in industry are merged and everybody should feel free to touch industry again ;-) |
I finished 6. (except energy2030) |
I started with 1. Nearly all files are now pyright strict. But there are a lot of type ignores. These should be removed in a next step ... |
|
Refactoring to bring all sectors in a consistent form:
1. Make every file
# pyright: strict
2. Remove empty dataclasses and all their references
@bgrundmann:
@bgrundmann:
4. Make every possible dataclass
@dataclass(kw_only=True)
5. Put a comment on top of every sector with a link to the matching part in readthedocs
6. Make the interface of each sector more visible by putting it into a separate file like:
i18.py:
There are a lot of sectors which consume energy. All these sectors work in two steps:
Idea: create one file for energy_demand.py and one file for energy_sources.py and call the two calc methods in the init of the sector.
See: industry2018
Todo: Talk about a good naming for the two steps.
with the following rules:
The text was updated successfully, but these errors were encountered: