Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent Fields get deleted on Typo3 10 #612

Closed
danielDigitalArt opened this issue Dec 22, 2023 · 6 comments
Closed

Parent Fields get deleted on Typo3 10 #612

danielDigitalArt opened this issue Dec 22, 2023 · 6 comments
Labels

Comments

@danielDigitalArt
Copy link

danielDigitalArt commented Dec 22, 2023

Typo3 10.4.23
Mask Version 7.1.17 & 7.2.16

When using the Database Analyser it wants to delete some parent fields in the tt_content table:
image

While i was doing an upgrade to Typo3 11 i cleaned up the Database with the Analyser before the update, my recommendation is to not delete any fields or tables at this stage, because these Fields are later used in typo3 11 and Mask Version 8.3.7 on an update in the Upgrade wizard, which then fails like so:

An exception occurred while executing 
'UPDATE `tt_content` SET 
	`tx_mask_content_parent_uid` = `tx_mask_inhalt_parent`, 
	`tx_mask_content_tablenames` = ?, 
	`tx_mask_content_role` = ? 
WHERE 
`tx_mask_inhalt_parent` <> ?'

When i found the Element which was using this Mask Element i found that the contents were lost. And the Upgrade Wizard can not finish this task.

After reverting back to the old Database Version (Backup from typo3 10.4.23 before any changes) i was able to let the upgrade wizard run through the full process, because i now did not let it remove any tables or fields, so the Upgrade Wizard is happy now.

@nhovratov
Copy link
Collaborator

Yes, this is a general advise to not delete any fields or tables during a TYPO3 update process if you are unsure.

@nhovratov nhovratov added the info label Dec 22, 2023
@nhovratov nhovratov pinned this issue Dec 22, 2023
@danielDigitalArt
Copy link
Author

I Agree, the thing is the system was not touched for a long time, thus i found the Database changes coming from the last update process i did about 2 years ago, so normally i would have removed these fields back then.
It seems to me like the Fields were removed a long time ago and now mask needs these fields in order to update properly.

@nhovratov
Copy link
Collaborator

The persistence was changed in Mask v8.1, see: https://docs.typo3.org/p/mask/mask/8.3/en-us/Upgrade/Index.html#from-v8-0-x-or-lower

@danielDigitalArt
Copy link
Author

danielDigitalArt commented Dec 22, 2023

Hmm, i updated from mask 7.1.17 => 8.3.7 where 8.3.7 was referencing fields which got removed in 7.1.17.

Suggestion:
Add a note to the Upgrade guide, to section 7, where it states that users should not let the Database Analyzer delete any fields with a Name like "tx_mask_***_parent" then we might need another version of 7 which claims that it needs these fields, so the Database Analyser will not delete these Fields, then the Update in Version 8 should work properly and only then let the Analyser remove these fields.

@nhovratov
Copy link
Collaborator

@danielDigitalArt This can't be. The change is only in Mask >= v8.1
The only reason the fields would be removed is if you deleted the field.

Add a note to the Upgrade guide, to section 7, where it states that users should not let the Database Analyzer delete any fields with a Name like "tx_mask_***_parent"

I can add a note, good idea.

@nhovratov
Copy link
Collaborator

Closing due to lack of feedback. If you still need help, please reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants