Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add option to disable php-ide-serenata.general.projectOpenCount #499

Open
sbrl opened this issue Mar 8, 2020 · 2 comments
Open

Comments

@sbrl
Copy link

sbrl commented Mar 8, 2020

I use the sync-settings package to synchronise my Atom settings across devices. Recently, it's been popping up every time I start Atom to tell me that the settings have changed, and I need to choose whether to backup or restore:

Selection_010

When I click "view diff", I'm greeted with this:

Selection_011

It looks like Serenata is now keeping track of the number of times I've opened projects. This is really annoying - and slightly creepy. Is there any way to disable this? It doesn't seem to be obviously used for anything.

@Gert-dev
Copy link
Owner

Gert-dev commented Mar 8, 2020

I'm not familiar with how settings synchronization works, but I understand the annoyance. I think you you can avoid this by setting general.doNotAskForSupport to true.

There's really no point in incrementing this number beyond the current threshold of 10. The number is used to show a notification to the user "when he's been using the package for some time" (though some users may reach 10 project opens in a single day, whilst others might take months).

It's not sent anywhere or used anywhere else than in the linked location, in case you're worried about analytics/tracking - I don't like these myself, so I wanted to make the notification as unobtrusive as possible and allow permanently disabling it this way.

I will leave this open so we can move updating the setting only to when the threshold is not yet reached (i.e. move it inside the if statement below it).

@sbrl
Copy link
Author

sbrl commented Mar 10, 2020

Ah, thanks for that! I'll see if that fix works in the coming days.

I've actually been experiencing a number of crashes in Serenata too (it's been really unstable) - but I need to track that down before I can open a separate bug report about that.

Gert-dev added a commit that referenced this issue Mar 14, 2020
projectOpenCount is always incremented and saved, even though it's
not useful anymore after 10 opens. Skip saving it to avoid settings
synchronization from picking up changes.

Implements #499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants