Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to go to definition with ctrl + left mouse click? #511

Open
rrolla opened this issue Oct 4, 2020 · 8 comments
Open

How to go to definition with ctrl + left mouse click? #511

rrolla opened this issue Oct 4, 2020 · 8 comments
Labels

Comments

@rrolla
Copy link

rrolla commented Oct 4, 2020

Cannot understand how can I navigate in atom to the method definition inside class, like PhpStorm (ctrl + left mouse click)

@Gert-dev
Copy link
Owner

Gert-dev commented Nov 6, 2020

It is the same in Atom if you use hyperclick provided by atom-ide-ui. Since you also posted #510, are you sure Serenata is indexing your project correctly? Do you see anything being indexed the first time on opening the project or any errors in the developer tools console?

@rrolla
Copy link
Author

rrolla commented Nov 9, 2020

I will try to install hyperclick, and post my findings.

Quick question is this somewhere in your plugin documentation mentioned that you need to use hyperclick?

@Gert-dev
Copy link
Owner

Not directly since atom-ide-ui is already a hard dependency, causing it to be installed before you can use this package (or this one won't start); if it's not installed, you see a popup after installation that you need to install it.

atom-ide-ui includes a version of hyperclick that is necessary for this functionality to work. There is some documentation about it here.

@rrolla
Copy link
Author

rrolla commented Nov 16, 2020

After re-enabling https://github.com/facebookarchive/atom-ide-ui package I was able to ctrl+click once and it works, but after atom restart doesn't work anymore.

@rrolla
Copy link
Author

rrolla commented Nov 16, 2020

It is the same in Atom if you use hyperclick provided by atom-ide-ui. Since you also posted #510, are you sure Serenata is indexing your project correctly? Do you see anything being indexed the first time on opening the project or any errors in the developer tools console?

I can see that at project opening in the bottom near line endings there is a yellow blinking indicator and after some short time it gets green

information about system:

lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.1 LTS
Release:	20.04
Codename:	focal
php -v
PHP 7.4.3 (cli) (built: Oct  6 2020 15:47:56) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.3, Copyright (c), by Zend Technologies
php -m
[PHP Modules]
calendar
Core
ctype
date
dom
exif
FFI
fileinfo
filter
ftp
gettext
hash
iconv
json
libxml
mbstring
openssl
pcntl
pcre
PDO
pdo_sqlite
Phar
posix
readline
Reflection
session
shmop
SimpleXML
sockets
sodium
SPL
sqlite3
standard
sysvmsg
sysvsem
sysvshm
tokenizer
xml
xmlreader
xmlwriter
xsl
Zend OPcache
zlib

[Zend Modules]
Zend OPcache

@Gert-dev
Copy link
Owner

Strange that it works once, that implies at least some parts of the code got indexed successfully.

Did you have a chance to check out the developer tools console (Ctrl-Shift-I I believe, but you can also find it in the command palette somewhere).

@krzysztof-sikorski
Copy link

I also had similar problems with the hyperclick feature, but after uninstalling all packages I discovered that the same key combination (Ctrl+Click) is used in Atom's core engine to trigger "Multi Cursor On Click" feature.

I don't know why Ctrl+Click seemed to work right after installing the hyperclick package and only stopped working later, I guess this is a bug in Atom's package installer that temporarily gives higher priority to package's bindings over core engine's bindings, and normally core engine has priority over packages.

Anyway, I could not find any way to override binding for Ctrl+Click or define some other combination of keys+Click to trigger hyperclick navigation, the keymap.cson file is no help here because it only configures "pure-keyboard" bindings... so I think the only workaround for now is to just disable that "Multi Cursor On Click" feature in Atom settings. It is located in Editor tab, for some unknown reason it was put in the middle of line height settings...

@machitgarha
Copy link
Collaborator

Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants