Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metastore service needs to call logger.factory #4100

Closed
stefan-korn opened this issue Jan 23, 2024 · 1 comment
Closed

Metastore service needs to call logger.factory #4100

stefan-korn opened this issue Jan 23, 2024 · 1 comment

Comments

@stefan-korn
Copy link
Contributor

Describe the bug

The metastore service does not output correctly to the log because the logger service is not present.

Steps To Reproduce

for example if this exception is raised, there will be no entry in the log. If you cannot reproduce an exception here, you could just add a log call in the try-part and see that the message is not logged.

Expected behavior

message should be logged.

@paul-m
Copy link
Contributor

paul-m commented Mar 6, 2024

Thanks!

In this PR we deprecated LoggerTrait and made sure it was replaced with a more direct service injection: #4140

I'll close this issue and the associated PR. Feel free to open a new one if you find something else.

@paul-m paul-m closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants