Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Adding a new network, we need to strip the http:// prefix or show an error #115

Open
lucca65 opened this issue Jun 21, 2018 · 3 comments

Comments

@lucca65
Copy link

lucca65 commented Jun 21, 2018

To avoid problems like this:

image

@nsjames
Copy link
Contributor

nsjames commented Jun 22, 2018

Looking at this now, i'm not sure how you even got those in there.
https://github.com/EOSEssentials/Scatter/blob/master/src/views/NetworkView.vue#L60

It should have stripped the http:// off when you input it.

@lucca65
Copy link
Author

lucca65 commented Jun 22, 2018

Yeah, probably thats because I'm adding the network from javascript using the suggested settings:

const network = {
  blockchain: 'eos',
  host: 'http://dev.cryptolions.io',
  port: 38888
};

Probably it doesn't go through Vue's logic

@nsjames
Copy link
Contributor

nsjames commented Jun 23, 2018

Oh. That explains it :)
I'll fix that with an error message about not using protocols within the network since there's a protocol field on the network itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants