Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional requests while preparing transaction #139

Open
sim31 opened this issue Jul 19, 2018 · 3 comments
Open

Additional requests while preparing transaction #139

sim31 opened this issue Jul 19, 2018 · 3 comments

Comments

@sim31
Copy link

sim31 commented Jul 19, 2018

When making eos.transaction() call with eos returned from scatter it makes a bunch of get_info/get_block/get_abi requests:
image

When using [email protected] directly, however it's much better:
image

Plus I was able to reduce additional requests to just only one get_abi call, by providing transaction headers myself. Through scatter only one get_block request is saved this way.

Is where anyway to reduce the overhead?

Btw, does scatter have it's own version of eosjs which it uses? Because it looks a lot like this issue, which appears to be almost fixed in newest eosjs.

@nsjames
Copy link
Contributor

nsjames commented Jul 26, 2018

I'd suggest tagging onto the ticket I created on eosjs (EOSIO/eosjs#208). There's really nothing Scatter can do about this. Scatter already caches ABIs on our side but all those requests are coming from eosjs alone. I agree, it's a problem which needs a solution.

@nsjames nsjames closed this as completed Jul 26, 2018
@sim31
Copy link
Author

sim31 commented Jul 26, 2018

Why I don't see that many unnecessary requests when using eosjs directly?

@nsjames
Copy link
Contributor

nsjames commented Jul 27, 2018

Hmm, let me run some tests.
Scatter shouldn't be doing anything with get_block or get_info, and even if it does it does so through your injected eosjs which will match your version. I'll reopen for now and debug though.

@nsjames nsjames reopened this Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants