New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing LocationService #2

Open

socksrust opened this issue Aug 6, 2019 · 0 comments

socksrust commented Aug 6, 2019

We need a Location service, we can only add locations to Identities here:

https://github.com/GetScatter/walletpack/blob/master/packages/core/lib/services/utility/IdentityService.js

Which IMO isn't correct, as identities should only have a location ID, instead of the whole Location object.

Another options is to add a KeychainService instead of having those methods on a Keychain model:

walletpack/packages/core/lib/models/Keychain.js

Line 68 in 02d59a8

updateOrPushLocation(location){

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment