Read and update token request completions within a single closure for avoiding data race issues (#3683)

Author: laevandus

CHANGELOG.md

@@ -3,7 +3,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 # Upcoming
 
-### 🔄 Changed
+## StreamChat
+### 🐞 Fixed
+- Fix an issue where completion handler was called twice after waiting for token refresh [#3683](https://github.com/GetStream/stream-chat-swift/pull/3683)
 
 # [4.79.0](https://github.com/GetStream/stream-chat-swift/releases/tag/4.79.0)
 _May 28, 2025_

Sources/StreamChat/Repositories/AuthenticationRepository.swift

@@ -285,15 +285,13 @@ class AuthenticationRepository {
 
     func completeTokenCompletions(error: Error?) {
         let completionBlocks: [(Error?) -> Void]? = tokenQueue.sync(flags: .barrier) {
-            self._isGettingToken = false
             let completions = self._tokenRequestCompletions
-            return completions
-        }
-        completionBlocks?.forEach { $0(error) }
-        tokenQueue.async(flags: .barrier) {
+            self._isGettingToken = false
             self._tokenRequestCompletions = []
             self._consecutiveRefreshFailures = 0
+            return completions
         }
+        completionBlocks?.forEach { $0(error) }
     }
 
     private func updateToken(token: Token?, notifyTokenWaiters: Bool) {