Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize channel avatar view #734

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Link

https://linear.app/stream/issue/IOS-684/[swiftui]-make-channel-avatar-view-customizable

🎯 Goal

At the moment, there's no possibility to customize only the channel avatar view. If you want to change it, you need to implement several factory methods, all with bigger views involved.

🛠 Implementation

Exposed a new factory method.

🧪 Testing

Added snapshot tests for the customization, everything else should work the same as before.

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner January 29, 2025 10:46
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jan 29, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.58 MB 7.58 MB -6 KB 🚀

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

We just need to provide the missing public init and fix the tests 👍

Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@martinmitrevski martinmitrevski merged commit 29091e3 into develop Jan 29, 2025
11 of 12 checks passed
@martinmitrevski martinmitrevski deleted the customize-channel-avatar-view branch January 29, 2025 19:56
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants