Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MessageDisplayInfo properties being overwritten #737

Merged

Conversation

mmellau
Copy link
Contributor

@mmellau mmellau commented Jan 31, 2025

🔗 Issue Link

No open GitHub issue.

🎯 Goal

Fix an issue where showsMessageActions and showsBottomContainer are unintentionally reset to their default values when the handleLongPress is called. This causes incorrect UI behavior when displaying the reactions overlay.

🛠 Implementation

Updated handleLongPress(messageDisplayInfo:) to make sure that showsMessageActions and showsBottomContainer values are preserved when creating a new MessageDisplayInfo instance.

🧪 Testing

  1. Configure MessageDisplayInfo with showsMessageActions and showsBottomContainer set to false
  2. Open the chat screen and pull up the keyboard
  3. Long-press on a message
  4. Observe that showsMessageActions and showsBottomContainer revert to their default values (true)

🎨 Changes

No visual changes but this fixes a bug affecting the overlay behavior when reacting to messages.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@mmellau mmellau requested a review from a team as a code owner January 31, 2025 08:45
@laevandus
Copy link
Contributor

@mmellau Thank you for your contribution. I have verified the unintended behaviour where the message actions views is rendered although display options define that it should not.

@laevandus laevandus merged commit f172363 into GetStream:develop Feb 4, 2025
1 of 4 checks passed
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants