Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusion path doesn’t seem to work - Version=3.0.3 #71

Open
tekstaker opened this issue Dec 1, 2022 · 3 comments
Open

Exclusion path doesn’t seem to work - Version=3.0.3 #71

tekstaker opened this issue Dec 1, 2022 · 3 comments
Labels
question Further information is requested ready for dev

Comments

@tekstaker
Copy link

I've tried all kinds of combos, but the exclusion path field seems to be ignored.

We have a multi-tenant instance of EPi.

We tried:
https:\domain.com\path
https:\domain.com\path*
https:\domain.com\path*

\path
\path*
\path
\path*

*\path
\path
*\path
*\path*

path
path*
path
path*

*path
path
*path
*path*

https:\domain.com\path%
https:\domain.com\path%

\path%
\path%

%\path
%\path%
%\path
%\path%

path%
path%

%path
%path%
%path
%path%

@tekstaker tekstaker changed the title Exclusion path doesn’t seem to work Exclusion path doesn’t seem to work - Version=3.0.3 Dec 1, 2022
@tekstaker
Copy link
Author

Now, this may be caused by us using the 'Include trailing slash' instruction in the startup of our EPi project. I'll reopen this if I can confirm this issue is NOT caused by the trailing slash directive.

@marisks
Copy link
Member

marisks commented Jan 27, 2023

@tekstaker Is this fixed now for you?

@marisks marisks added the question Further information is requested label Jan 27, 2023
@dan-valea
Copy link

dan-valea commented Mar 30, 2023

I'm experiencing the same issue in version 3.1.0. Paths to avoid are not properly processed when using Optimizely RoutingOptions.UseTrailingSlash = false. This is due to the UrlFilter calling AddTailingSlash before comparing the URLs.
So if your url is /cart and the path to avoid is /cart ... it will end up checking /cart.StartsWith(/cart/) ... which is false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested ready for dev
Projects
None yet
Development

No branches or pull requests

4 participants