Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unofficial Homestuck Collection does not support clipboard-read and clipboard-write attributes #347

Open
EtchJetty opened this issue Mar 2, 2022 · 1 comment
Labels
bug Something isn't working implementation Adjust how something is implemented w/o directly affecting features mods This relates to the mod system and user-generated content

Comments

@EtchJetty
Copy link

EtchJetty commented Mar 2, 2022

It is impossible to give clipboard access to iframes.
According to #w3c/webappsec-permissions-policy#322 (comment) and this bug report, chrome versions 81-85 had broken iframe clipboard permissions. The feature policies clipboard-write and clipboard-allow were created to solve this issue, but the UHC seems to not recognize them. (The bug was fixed in Chrome 85, which was first used in Electron 10.0, a version newer than the UHC's Electron.)

To Reproduce
Steps to reproduce the behavior:

  1. Make an iframe which includes a clipboard link. https://smart-flicker-baroness.glitch.me/ includes one.
  2. The same iframe that works in modern browsers (<iframe ... allow="clipboard-read; clipboard-write;">) will fail in the UHC2.

Expected behavior
The parent window (the UHC) should recognize the policies and change behavior accordingly; this does not happen.

Screenshots
Screen Shot 2022-03-01 at 9 04 58 PM
Screen Shot 2022-03-01 at 9 05 50 PM

Desktop (please complete the following information):

  • Application version: v2.0.5
  • Asset pack version: v2
  • OS: MacBook Air (M1, 2020), running macOS Monterey 12.1 (21C52)

Additional context
iframe is meant to be used for the "share" button in this project. The iframe is in use here, with security policies functioning as expected.

Here is a link to a mod file which includes the iframe within its template.

@EtchJetty EtchJetty added the bug Something isn't working label Mar 2, 2022
@GiovanH GiovanH added implementation Adjust how something is implemented w/o directly affecting features mods This relates to the mod system and user-generated content labels Mar 2, 2022
@GiovanH GiovanH added this to the v3 (Enhancements) milestone Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working implementation Adjust how something is implemented w/o directly affecting features mods This relates to the mod system and user-generated content
Projects
None yet
Development

No branches or pull requests

2 participants