Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links to website (ie YouTube) not working after the update #601

Closed
Meufob opened this issue Jul 18, 2024 · 6 comments
Closed

Links to website (ie YouTube) not working after the update #601

Meufob opened this issue Jul 18, 2024 · 6 comments
Labels
awaiting approval This has been resolved and is waiting in a PR bug Something isn't working implementation Adjust how something is implemented w/o directly affecting features question Further information is requested

Comments

@Meufob
Copy link

Meufob commented Jul 18, 2024

Clicking on any link that would bring to a website outside the app makes it search inside of it instead.
@Meufob Meufob added the bug Something isn't working label Jul 18, 2024
@school-dave
Copy link

this and also trying to open the "Cheerfulbear - PLAY ME" and "The origin story." of Sweet Bro & Hella Jeff (and maybe other similar links) fails to open correctly in an external browser (it 404s) since the update, at least for me

GiovanH added a commit that referenced this issue Jul 29, 2024
@GiovanH
Fix bad link logic when opening asset uris directly (resolves #601)
0bb7e9c
GiovanH added a commit that referenced this issue Jul 29, 2024
@GiovanH
Fix bad link logic when opening asset uris directly (resolves #601)
5620e9c
@GiovanH GiovanH added implementation Adjust how something is implemented w/o directly affecting features awaiting approval This has been resolved and is waiting in a PR labels Jul 29, 2024
@kittenchilly
Copy link
Contributor

This didn't fix external links it seems. If you try to go to hsmusic.wiki or homestuck.bandcamp.com from the music page it just leads back to the main page and doesn't open anything.

@GiovanH GiovanH removed the awaiting approval This has been resolved and is waiting in a PR label Aug 23, 2024
@GiovanH
Copy link
Owner

GiovanH commented Aug 24, 2024

External links working in the webapp. I also can't reproduce this in 2.5.2 of the app; can someone please confirm that 2.5.2 still has this issue?

@GiovanH GiovanH added awaiting approval This has been resolved and is waiting in a PR question Further information is requested labels Aug 24, 2024
@OverProgram
Copy link

Can confirm - in version 2.5.2 of the app opening the Homestuck Music Wiki link on the music page just leads you to the main page (seems to be on the same tab too)

GiovanH added a commit that referenced this issue Aug 24, 2024
@GiovanH
Fix link handling bug unique to the final electron build (resolves #601)
85ccd80
GiovanH added a commit that referenced this issue Aug 24, 2024
@GiovanH
Fix link handling bug unique to the final electron build (resolves #601)
c87714d
@Meufob
Copy link
Author

Meufob commented Aug 29, 2024

Can confirm external links still don't work in 2.5.2.

@kittenchilly
Copy link
Contributor

Can confirm external links still don't work in 2.5.2.

Update to 2.5.4, they should work now

@GiovanH GiovanH closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting approval This has been resolved and is waiting in a PR bug Something isn't working implementation Adjust how something is implemented w/o directly affecting features question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@GiovanH @OverProgram @kittenchilly @Meufob @school-dave