Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website responsiveness #15

Open
AvaniVerma opened this issue Jul 8, 2018 · 10 comments
Open

Website responsiveness #15

AvaniVerma opened this issue Jul 8, 2018 · 10 comments
Labels
bug Something isn't working enhancement New feature or request GSSoC

Comments

@AvaniVerma
Copy link
Collaborator

  1. It's not entirely responsive between the width range 771 and 990
  2. Check the warning message in console. There's a body tag in div
  3. Increase the font size of 'Kranti' to make it significantly bigger than that of the nav contents, especially on bigger screen.
  4. Make the logo a link that redirects to the home page.

To test please go to the link : https://codesandbox.io/s/github/amritsrivastava/Kranti/tree/amrit-patch-1

@AvaniVerma AvaniVerma added enhancement New feature or request GSSoC bug Something isn't working labels Jul 8, 2018
@devesh-verma
Copy link

I would like to take this one up. Plz assign me this

@AvaniVerma
Copy link
Collaborator Author

Sure @devshiva619 Go ahead

@devesh-verma
Copy link

Can u assign it to me?

@shreyateeza
Copy link

I would like to work on this issue if @devshiva619 won't work. 😅

@ayush221b
Copy link

@AvaniVerma Is this issue still open? I would like to work on it. I have a fairly simple solution for the responsiveness problem and I can address the other points too.

@devesh-verma
Copy link

hey @ayush221b would you like to share your solution?

@ayush221b
Copy link

ayush221b commented Jul 10, 2018

Yeah sure. Just replace <nav className="navbar navbar-default navbar-fixed-top"> with <nav className="navbar navbar-default navbar-static-top"> in Header.js

This should do the trick.

@devesh-verma
Copy link

@AvaniVerma This will be done by tonight.
@ayush221b your approach was right, the only issue with that is the navbar becomes very broad.

@adi44
Copy link

adi44 commented Jul 25, 2018

yes

@AvaniVerma
Copy link
Collaborator Author

@adi44 Please work on it and tell us how much time you'll need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request GSSoC
Projects
None yet
5 participants