Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OS port selection for the local OAuth server #913

Open
fbochu opened this issue Jun 17, 2024 · 1 comment
Open

Use OS port selection for the local OAuth server #913

fbochu opened this issue Jun 17, 2024 · 1 comment
Labels
good first issue Good for newcomers status:new This issue needs to be reviewed type:feature Feature request

Comments

@fbochu
Copy link
Contributor

fbochu commented Jun 17, 2024

Is your feature request related to a problem? Please describe.

In the OAuthClient, we start a local HTTP server by trying out a series of ports. However the port selection could be made by the operating system by passing 0 as port number.

Describe the solution you'd like

from http.server import HTTPServer, SimpleHTTPRequestHandler
server = HTTPServer(("127.0.0.1", 0), SimpleHTTPRequestHandler)
print(server.server_address, server.server_name, server.server_port)
@fbochu fbochu added type:feature Feature request status:new This issue needs to be reviewed labels Jun 17, 2024
@agateau-gg
Copy link
Collaborator

Sounds like a good idea. I am going to mark this one as a good first issue.

@agateau-gg agateau-gg added the good first issue Good for newcomers label Jun 24, 2024
@GitGuardian GitGuardian deleted a comment Aug 30, 2024
@GitGuardian GitGuardian deleted a comment Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers status:new This issue needs to be reviewed type:feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants