Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

"Mentioned" issues are not sorted by date #2649

Closed
BasThomas opened this issue Feb 22, 2019 · 7 comments
Closed

"Mentioned" issues are not sorted by date #2649

BasThomas opened this issue Feb 22, 2019 · 7 comments
Labels
🐛 bug Unintended behaviour within the app

Comments

@BasThomas
Copy link
Collaborator

BasThomas commented Feb 22, 2019

Referencing #2612

Describe the bug
Take a look at only mentioned issues, and observe they are not sorted by date

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Inbox"
  2. Click on Inbox
  3. Click on Mentioned
  4. See error

Expected behavior
A list of issues that is sorted by date, latest on top

Screenshots
screenshot

Request:

curl -v -X GET 'https://api.github.com/issues?access_token=123filter=mentioned&page=1&per_page=50' -H 'User-Agent: Freetime/1.27.1 (com.whoisryannystrom.freetime; build:1546622353; iOS 12.1.4) Alamofire/4.4.0' -H 'Accept-Language: en-DE;q=1.0, de-DE;q=0.9, nl-DE;q=0.8' -H 'Authorization: token 7e713728cee1b78872817efad46a940ce65af232' -H 'Accept: application/vnd.github.merge-info-preview+json' -H 'Accept-Encoding: gzip;q=1.0, compress;q=0.5' -H 'Cookie: logged_in=no;' 
@BasThomas BasThomas added the 🐛 bug Unintended behaviour within the app label Feb 22, 2019
@akarataev
Copy link
Contributor

I'll take a look at this, if nobody is against.

@ijm8710
Copy link

ijm8710 commented Mar 3, 2019

@BasThomas I think this is slightly different then the ticket I opened that you referenced. My older ticket focused on the aggregation of all the issues within a specific filter type, aka created or mentioned, and them all showing up consistent with the site.

Your ticket revolves around time stamps. Assuming we are identifying the same thing on this one, what I noticed is that GitHub issue tickets will not fall in chronological order specifically when you yourself are the only one to post a new comment. Unless someone else comments after, the timestamp will update to newer but since there is no new activity for you to review, it doesn’t bump it to the top. I actually wish it sorted chronologically regardless but it’s not an app error but just how GitHub handles things (the site actually will show it the exact same way). I have even emailed them directly about this requesting that they added an option to sort chronologically for all tickets, even if you are the only updater.

If we are on the same page here and you agree, I would love you to send GitHub another ticket on this to add visibility to what I wrote and hopefully influence them more to accommodate. If it’s something different, apologies and carry on.

@BasThomas
Copy link
Collaborator Author

Interesting, @ijm8710. It feels like it would be behaving as expected then, as of now? It’s a bit confusing though. I’m not sure what the UX would look like, but GitHawk could add it as an option to sort by “last updated”? What do you think?

Sent with GitHawk

@ijm8710
Copy link

ijm8710 commented Mar 3, 2019

Sounds like Ryan was against it

If you and I are on same page of having it sort chronologically, regardless of whether the last update was made by “you”/“not you”, the best way to drive it would be to nudge GitHub like I did. Like I said, I would love another voice to echo the request I already made to them myself!

@ijm8710
Copy link

ijm8710 commented Mar 3, 2019

Ps any idea if Ryan just wanted a little break or if he was trying to back away from this in general. Either way I’m super appreciate of the app and the hard work that went into it, was just curious if you expect him to pop back in whenever he so chooses (which is obv completely his call) or if it would make sense to have more people at his admin level to perhaps keep driving innovation align to what he would want

@BasThomas
Copy link
Collaborator Author

All I know is that he's not active at the moment.

@akarataev
Copy link
Contributor

@BasThomas hello,

Please see #2663 how you will have the opportunity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Unintended behaviour within the app
Projects
None yet
Development

No branches or pull requests

3 participants