From 310d837cff8d42e574594e59a1a3d23b7673bc6a Mon Sep 17 00:00:00 2001 From: jericho Date: Thu, 20 Jun 2024 13:48:36 -0400 Subject: [PATCH 1/2] (#598) Upgrade Octokit reference To addresses issues with int overflows. This was fixed in Octokit by changing int to long, in some places. In addition, changes IssueComment.Id to long to match the underlying type. --- src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj | 2 +- .../GitReleaseManager.Core.Tests.csproj | 2 +- src/GitReleaseManager.Core/GitReleaseManager.Core.csproj | 2 +- src/GitReleaseManager.Core/Model/IssueComment.cs | 2 +- src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj | 2 +- src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj index fbb74a15..25ec22aa 100644 --- a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj +++ b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj @@ -23,7 +23,7 @@ runtime; build; native; contentfiles; analyzers; buildtransitive all - + diff --git a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj index 4d4c3981..36f70661 100644 --- a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj +++ b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj @@ -26,7 +26,7 @@ - + \ No newline at end of file diff --git a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj index ea4a4b55..daa5cf1d 100644 --- a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj +++ b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj @@ -24,7 +24,7 @@ all - + diff --git a/src/GitReleaseManager.Core/Model/IssueComment.cs b/src/GitReleaseManager.Core/Model/IssueComment.cs index 3d67fe5b..a1596a34 100644 --- a/src/GitReleaseManager.Core/Model/IssueComment.cs +++ b/src/GitReleaseManager.Core/Model/IssueComment.cs @@ -5,7 +5,7 @@ public class IssueComment /// /// Gets or sets the issue comment Id. /// - public int Id { get; set; } + public long Id { get; set; } /// /// Gets or sets details about the issue comment. diff --git a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj index 4f2362bd..7d724be5 100644 --- a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj +++ b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj @@ -26,6 +26,6 @@ - + \ No newline at end of file diff --git a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj index 213a1f38..e362443d 100644 --- a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj +++ b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj @@ -39,7 +39,7 @@ all - + From 36e06da27765558f56070787e1af242a3567053e Mon Sep 17 00:00:00 2001 From: Gary Ewan Park Date: Tue, 9 Jul 2024 20:53:36 +0100 Subject: [PATCH 2/2] (build) Skip running Codecov There seems to be an error uploading reports to Codecov in the recent builds. Rather than try to fix this just now, let's simply skip it, as it isn't a requirement for just now. --- recipe.cake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/recipe.cake b/recipe.cake index 8ca2b04b..a8725827 100644 --- a/recipe.cake +++ b/recipe.cake @@ -18,7 +18,8 @@ BuildParameters.SetParameters(context: Context, integrationTestScriptPath: "./tests/integration/tests.cake", twitterMessage: standardNotificationMessage, preferredBuildProviderType: BuildProviderType.GitHubActions, - gitterMessage: "@/all " + standardNotificationMessage); + gitterMessage: "@/all " + standardNotificationMessage, + shouldRunCodecov: false); BuildParameters.PackageSources.Add(new PackageSourceData(Context, "GPR", "https://nuget.pkg.github.com/GitTools/index.json", FeedType.NuGet, false));