From 310d837cff8d42e574594e59a1a3d23b7673bc6a Mon Sep 17 00:00:00 2001 From: jericho Date: Thu, 20 Jun 2024 13:48:36 -0400 Subject: [PATCH 01/15] (#598) Upgrade Octokit reference To addresses issues with int overflows. This was fixed in Octokit by changing int to long, in some places. In addition, changes IssueComment.Id to long to match the underlying type. --- src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj | 2 +- .../GitReleaseManager.Core.Tests.csproj | 2 +- src/GitReleaseManager.Core/GitReleaseManager.Core.csproj | 2 +- src/GitReleaseManager.Core/Model/IssueComment.cs | 2 +- src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj | 2 +- src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj index fbb74a15..25ec22aa 100644 --- a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj +++ b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj @@ -23,7 +23,7 @@ runtime; build; native; contentfiles; analyzers; buildtransitive all - + diff --git a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj index 4d4c3981..36f70661 100644 --- a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj +++ b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj @@ -26,7 +26,7 @@ - + \ No newline at end of file diff --git a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj index ea4a4b55..daa5cf1d 100644 --- a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj +++ b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj @@ -24,7 +24,7 @@ all - + diff --git a/src/GitReleaseManager.Core/Model/IssueComment.cs b/src/GitReleaseManager.Core/Model/IssueComment.cs index 3d67fe5b..a1596a34 100644 --- a/src/GitReleaseManager.Core/Model/IssueComment.cs +++ b/src/GitReleaseManager.Core/Model/IssueComment.cs @@ -5,7 +5,7 @@ public class IssueComment /// /// Gets or sets the issue comment Id. /// - public int Id { get; set; } + public long Id { get; set; } /// /// Gets or sets details about the issue comment. diff --git a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj index 4f2362bd..7d724be5 100644 --- a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj +++ b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj @@ -26,6 +26,6 @@ - + \ No newline at end of file diff --git a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj index 213a1f38..e362443d 100644 --- a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj +++ b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj @@ -39,7 +39,7 @@ all - + From 36e06da27765558f56070787e1af242a3567053e Mon Sep 17 00:00:00 2001 From: Gary Ewan Park Date: Tue, 9 Jul 2024 20:53:36 +0100 Subject: [PATCH 02/15] (build) Skip running Codecov There seems to be an error uploading reports to Codecov in the recent builds. Rather than try to fix this just now, let's simply skip it, as it isn't a requirement for just now. --- recipe.cake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/recipe.cake b/recipe.cake index 8ca2b04b..a8725827 100644 --- a/recipe.cake +++ b/recipe.cake @@ -18,7 +18,8 @@ BuildParameters.SetParameters(context: Context, integrationTestScriptPath: "./tests/integration/tests.cake", twitterMessage: standardNotificationMessage, preferredBuildProviderType: BuildProviderType.GitHubActions, - gitterMessage: "@/all " + standardNotificationMessage); + gitterMessage: "@/all " + standardNotificationMessage, + shouldRunCodecov: false); BuildParameters.PackageSources.Add(new PackageSourceData(Context, "GPR", "https://nuget.pkg.github.com/GitTools/index.json", FeedType.NuGet, false)); From ea368076378eb5e9241941985c8467c31acd93b6 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 9 Jul 2024 20:08:01 +0000 Subject: [PATCH 03/15] Bump Roslynator.Analyzers from 4.6.2 to 4.12.4 in /src Bumps [Roslynator.Analyzers](https://github.com/dotnet/roslynator) from 4.6.2 to 4.12.4. - [Release notes](https://github.com/dotnet/roslynator/releases) - [Changelog](https://github.com/dotnet/roslynator/blob/main/ChangeLog.md) - [Commits](https://github.com/dotnet/roslynator/compare/v4.6.2...v4.12.4) --- updated-dependencies: - dependency-name: Roslynator.Analyzers dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- src/Directory.Build.props | 66 +++++++++++++++++++-------------------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 22f7beee..7e569b77 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -1,34 +1,34 @@ - - - pdbonly - true - CS1591 - AllEnabledByDefault - - - - - CustomDictionary.xml - - - - - - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - - - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - All - - + + + pdbonly + true + CS1591 + AllEnabledByDefault + + + + + CustomDictionary.xml + + + + + + + all + runtime; build; native; contentfiles; analyzers; buildtransitive + + + + all + runtime; build; native; contentfiles; analyzers; buildtransitive + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + All + + \ No newline at end of file From 8ec74eba6d3879be16290b825cad4c47507297ac Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 9 Jul 2024 20:24:23 +0000 Subject: [PATCH 04/15] Bump Microsoft.CodeAnalysis.NetAnalyzers from 7.0.4 to 8.0.0 in /src Bumps [Microsoft.CodeAnalysis.NetAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 7.0.4 to 8.0.0. - [Release notes](https://github.com/dotnet/roslyn-analyzers/releases) - [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/main/PostReleaseActivities.md) - [Commits](https://github.com/dotnet/roslyn-analyzers/commits) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.NetAnalyzers dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- src/Directory.Build.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 7e569b77..a8790684 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -14,7 +14,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive From 0dcc175fefbadc9d84263ee81b442a915047d0f2 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 9 Jul 2024 21:05:53 +0000 Subject: [PATCH 05/15] Bump Destructurama.Attributed and Serilog in /src Bumps [Destructurama.Attributed](https://github.com/destructurama/attributed) and [Serilog](https://github.com/serilog/serilog). These dependencies needed to be updated together. Updates `Destructurama.Attributed` from 3.1.0 to 4.0.0 - [Release notes](https://github.com/destructurama/attributed/releases) - [Commits](https://github.com/destructurama/attributed/compare/3.1.0...4.0.0) Updates `Serilog` from 3.0.1 to 3.1.1 - [Release notes](https://github.com/serilog/serilog/releases) - [Commits](https://github.com/serilog/serilog/compare/v3.0.1...v3.1.1) --- updated-dependencies: - dependency-name: Destructurama.Attributed dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Serilog dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- src/Directory.Build.props | 2 +- .../GitReleaseManager.Cli.csproj | 62 +++++----- .../GitReleaseManager.Core.csproj | 98 ++++++++-------- .../GitReleaseManager.Tool.csproj | 106 +++++++++--------- 4 files changed, 134 insertions(+), 134 deletions(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index a8790684..6cc0c1b8 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -18,7 +18,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj index 25ec22aa..b80bb750 100644 --- a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj +++ b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj @@ -1,32 +1,32 @@ - - - 8.0 - Exe - GitReleaseManager - net6.0 - true - true - win-x64 - GitReleaseManager.Cli - Create release notes in markdown given a milestone - false - $(NoWarn);CA1707; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - - + + + 8.0 + Exe + GitReleaseManager + net6.0 + true + true + win-x64 + GitReleaseManager.Cli + Create release notes in markdown given a milestone + false + $(NoWarn);CA1707; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj index daa5cf1d..903811d7 100644 --- a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj +++ b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj @@ -1,50 +1,50 @@ - - - - - - 8.0 - net6.0;net7.0 - GitReleaseManager.Core - Create release notes in markdown given a milestone - false - $(NoWarn);CA1707; - true - - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - - - - - - True - True - ReleaseTemplates.tt - - - - - TextTemplatingFileGenerator - ReleaseTemplates.g.cs - - - - - - + + + + + + 8.0 + net6.0;net7.0 + GitReleaseManager.Core + Create release notes in markdown given a milestone + false + $(NoWarn);CA1707; + true + + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + + + + + + + True + True + ReleaseTemplates.tt + + + + + TextTemplatingFileGenerator + ReleaseTemplates.g.cs + + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj index e362443d..c99cf44f 100644 --- a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj +++ b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj @@ -1,54 +1,54 @@ - - - - 8.0 - Exe - GitReleaseManager - - true - net6.0;net7.0 - dotnet-gitreleasemanager - GitReleaseManager.Tool - - GitReleaseManager Tool - GitTools Contributors - https://github.com/GitTools/GitReleaseManager - false - github release notes create export - Tool for creating and exporting releases for software applications from online Version Control Systems - Copyright (c) 2015 - Present - GitTools Contributors - MIT - package_icon.png - https://github.com/GitTools/GitReleaseManager/releases - git - https://github.com/GitTools/GitReleaseManager.git - $(NoWarn);CA1707; - - - - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - - - - - - True - - - + + + + 8.0 + Exe + GitReleaseManager + + true + net6.0;net7.0 + dotnet-gitreleasemanager + GitReleaseManager.Tool + + GitReleaseManager Tool + GitTools Contributors + https://github.com/GitTools/GitReleaseManager + false + github release notes create export + Tool for creating and exporting releases for software applications from online Version Control Systems + Copyright (c) 2015 - Present - GitTools Contributors + MIT + package_icon.png + https://github.com/GitTools/GitReleaseManager/releases + git + https://github.com/GitTools/GitReleaseManager.git + $(NoWarn);CA1707; + + + + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + + + + + + + True + + + \ No newline at end of file From 78906fdfd8383ac62b1b80d197c47ee6047ed587 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 9 Jul 2024 21:18:41 +0000 Subject: [PATCH 06/15] Bump Scriban from 5.9.0 to 5.10.0 in /src Bumps [Scriban](https://github.com/scriban/scriban) from 5.9.0 to 5.10.0. - [Release notes](https://github.com/scriban/scriban/releases) - [Changelog](https://github.com/scriban/scriban/blob/master/changelog.md) - [Commits](https://github.com/scriban/scriban/compare/5.9.0...5.10.0) --- updated-dependencies: - dependency-name: Scriban dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- src/GitReleaseManager.Core/GitReleaseManager.Core.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj index 903811d7..6088903c 100644 --- a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj +++ b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj @@ -25,7 +25,7 @@ - + From 49f47c3d4972b124d40a2fd3de3b6f5d798070b1 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 10 Jul 2024 07:03:37 +0000 Subject: [PATCH 07/15] Bump ApprovalTests from 5.9.0 to 6.0.0 in /src Bumps [ApprovalTests](https://github.com/approvals/ApprovalTests.Net) from 5.9.0 to 6.0.0. - [Release notes](https://github.com/approvals/ApprovalTests.Net/releases) - [Commits](https://github.com/approvals/ApprovalTests.Net/commits) --- updated-dependencies: - dependency-name: ApprovalTests dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .../GitReleaseManager.Core.Tests.csproj | 62 +++++++++---------- .../GitReleaseManager.Tests.csproj | 60 +++++++++--------- 2 files changed, 61 insertions(+), 61 deletions(-) diff --git a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj index 36f70661..78d92bb5 100644 --- a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj +++ b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj @@ -1,32 +1,32 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.Core.Tests - Test Project for GitReleaseManager.Core - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.Core.Tests + Test Project for GitReleaseManager.Core + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj index 7d724be5..acb3686a 100644 --- a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj +++ b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj @@ -1,31 +1,31 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.Tests - Test Project for GitReleaseManager - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.Tests + Test Project for GitReleaseManager + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + + \ No newline at end of file From 0d43588e607ff6e79d688ae2130a6d0997e4cc69 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 10 Jul 2024 07:23:21 +0000 Subject: [PATCH 08/15] Bump Microsoft.SourceLink.GitHub from 1.1.1 to 8.0.0 in /src Bumps [Microsoft.SourceLink.GitHub](https://github.com/dotnet/sourcelink) from 1.1.1 to 8.0.0. - [Release notes](https://github.com/dotnet/sourcelink/releases) - [Commits](https://github.com/dotnet/sourcelink/commits) --- updated-dependencies: - dependency-name: Microsoft.SourceLink.GitHub dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .../GitReleaseManager.Cli.csproj | 2 +- .../GitReleaseManager.Core.Tests.csproj | 2 +- .../GitReleaseManager.Core.csproj | 2 +- .../GitReleaseManager.IntegrationTests.csproj | 62 +++++++++---------- .../GitReleaseManager.Tests.csproj | 2 +- .../GitReleaseManager.Tool.csproj | 2 +- 6 files changed, 36 insertions(+), 36 deletions(-) diff --git a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj index b80bb750..82474e8e 100644 --- a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj +++ b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj @@ -19,7 +19,7 @@ - + runtime; build; native; contentfiles; analyzers; buildtransitive all diff --git a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj index 78d92bb5..9061c7fd 100644 --- a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj +++ b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj @@ -19,7 +19,7 @@ - + runtime; build; native; contentfiles; analyzers; buildtransitive all diff --git a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj index 6088903c..967c4c05 100644 --- a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj +++ b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj @@ -19,7 +19,7 @@ - + runtime; build; native; contentfiles; analyzers; buildtransitive all diff --git a/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj b/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj index c1a6630f..4dce32be 100644 --- a/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj +++ b/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj @@ -1,32 +1,32 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.IntegrationTests - Integration Test Project for GitReleaseManager - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.IntegrationTests + Integration Test Project for GitReleaseManager + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj index acb3686a..8d059e56 100644 --- a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj +++ b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj @@ -19,7 +19,7 @@ - + runtime; build; native; contentfiles; analyzers; buildtransitive all diff --git a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj index c99cf44f..f2360619 100644 --- a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj +++ b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj @@ -34,7 +34,7 @@ - + runtime; build; native; contentfiles; analyzers; buildtransitive all From 426730e272ad0f2a4738315c4568208a80987b37 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 10 Jul 2024 07:36:32 +0000 Subject: [PATCH 09/15] Bump Microsoft.Extensions.DependencyInjection in /src Bumps [Microsoft.Extensions.DependencyInjection](https://github.com/dotnet/runtime) from 7.0.0 to 8.0.0. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](https://github.com/dotnet/runtime/compare/v7.0.0...v8.0.0) --- updated-dependencies: - dependency-name: Microsoft.Extensions.DependencyInjection dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj | 2 +- src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj index 82474e8e..c3202950 100644 --- a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj +++ b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj @@ -18,7 +18,7 @@ - + runtime; build; native; contentfiles; analyzers; buildtransitive all diff --git a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj index f2360619..ecf1fd24 100644 --- a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj +++ b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj @@ -33,7 +33,7 @@ - + runtime; build; native; contentfiles; analyzers; buildtransitive all From 81e6e44728a982c9bbef66c98a892c874b0ffc4a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 10 Jul 2024 07:47:20 +0000 Subject: [PATCH 10/15] Bump Serilog.Sinks.Console and Serilog in /src Bumps Serilog.Sinks.Console and Serilog. These dependencies needed to be updated together. Updates `Serilog.Sinks.Console` from 4.1.0 to 6.0.0 Updates `Serilog` from 3.1.1 to 4.0.0 --- updated-dependencies: - dependency-name: Serilog.Sinks.Console dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Serilog dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- src/Directory.Build.props | 2 +- src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj | 2 +- .../GitReleaseManager.IntegrationTests.csproj | 2 +- src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 6cc0c1b8..63a9a074 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -18,7 +18,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj index c3202950..2f9dc0f9 100644 --- a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj +++ b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj @@ -24,7 +24,7 @@ all - + diff --git a/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj b/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj index 4dce32be..a7172621 100644 --- a/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj +++ b/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj @@ -25,7 +25,7 @@ - + diff --git a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj index ecf1fd24..eb9eff29 100644 --- a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj +++ b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj @@ -40,7 +40,7 @@ - + From e58de339b994f74dd9becdb607e7a078d90ad6ce Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 10 Jul 2024 07:55:30 +0000 Subject: [PATCH 11/15] Bump NGitLab from 6.39.0 to 6.51.1 in /src Bumps NGitLab from 6.39.0 to 6.51.1. --- updated-dependencies: - dependency-name: NGitLab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- src/GitReleaseManager.Core/GitReleaseManager.Core.csproj | 2 +- src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj index 967c4c05..6b2e9b04 100644 --- a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj +++ b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj @@ -23,7 +23,7 @@ runtime; build; native; contentfiles; analyzers; buildtransitive all - + diff --git a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj index eb9eff29..9c407a41 100644 --- a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj +++ b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj @@ -38,7 +38,7 @@ runtime; build; native; contentfiles; analyzers; buildtransitive all - + From 52ed0838584cc1e72fc44fa7de48ff0c11dfce5f Mon Sep 17 00:00:00 2001 From: Gary Ewan Park Date: Wed, 10 Jul 2024 10:53:08 +0100 Subject: [PATCH 12/15] (test) Introduce NUnit.Analyzers This will help aid in the transition to NUnit 4, where there have been some breaking changes. --- src/Directory.Build.props | 66 +++++------ .../GitReleaseManager.Cli.csproj | 62 +++++----- .../GitReleaseManager.Core.Tests.csproj | 66 ++++++----- .../GitReleaseManager.Core.csproj | 98 ++++++++-------- .../GitLabProviderIntegrationTests.cs | 8 ++ .../GitReleaseManager.IntegrationTests.csproj | 66 ++++++----- .../ReleaseNotesBuilderIntegrationTests.cs | 3 + .../GitReleaseManager.Tests.csproj | 64 ++++++----- .../ReleaseNotesBuilderTests.cs | 30 ++--- .../ReleaseNotesExporterTests.cs | 8 +- .../GitReleaseManager.Tool.csproj | 106 +++++++++--------- tests/integration/tests.cake | 4 +- 12 files changed, 302 insertions(+), 279 deletions(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 63a9a074..1edd6be7 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -1,34 +1,34 @@ - - - pdbonly - true - CS1591 - AllEnabledByDefault - - - - - CustomDictionary.xml - - - - - - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - - - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - All - - + + + pdbonly + true + CS1591 + AllEnabledByDefault + + + + + CustomDictionary.xml + + + + + + + all + runtime; build; native; contentfiles; analyzers; buildtransitive + + + + all + runtime; build; native; contentfiles; analyzers; buildtransitive + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + All + + \ No newline at end of file diff --git a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj index 2f9dc0f9..43f1f73b 100644 --- a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj +++ b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj @@ -1,32 +1,32 @@ - - - 8.0 - Exe - GitReleaseManager - net6.0 - true - true - win-x64 - GitReleaseManager.Cli - Create release notes in markdown given a milestone - false - $(NoWarn);CA1707; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - - + + + 8.0 + Exe + GitReleaseManager + net6.0 + true + true + win-x64 + GitReleaseManager.Cli + Create release notes in markdown given a milestone + false + $(NoWarn);CA1707; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj index 9061c7fd..9c04e0c4 100644 --- a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj +++ b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj @@ -1,32 +1,36 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.Core.Tests - Test Project for GitReleaseManager.Core - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.Core.Tests + Test Project for GitReleaseManager.Core + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + all + runtime; build; native; contentfiles; analyzers + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj index 6b2e9b04..bca953b3 100644 --- a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj +++ b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj @@ -1,50 +1,50 @@ - - - - - - 8.0 - net6.0;net7.0 - GitReleaseManager.Core - Create release notes in markdown given a milestone - false - $(NoWarn);CA1707; - true - - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - - - - - - True - True - ReleaseTemplates.tt - - - - - TextTemplatingFileGenerator - ReleaseTemplates.g.cs - - - - - - + + + + + + 8.0 + net6.0;net7.0 + GitReleaseManager.Core + Create release notes in markdown given a milestone + false + $(NoWarn);CA1707; + true + + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + + + + + + + True + True + ReleaseTemplates.tt + + + + + TextTemplatingFileGenerator + ReleaseTemplates.g.cs + + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.IntegrationTests/GitLabProviderIntegrationTests.cs b/src/GitReleaseManager.IntegrationTests/GitLabProviderIntegrationTests.cs index 91306939..169f9e91 100644 --- a/src/GitReleaseManager.IntegrationTests/GitLabProviderIntegrationTests.cs +++ b/src/GitReleaseManager.IntegrationTests/GitLabProviderIntegrationTests.cs @@ -24,7 +24,9 @@ public class GitLabProviderIntegrationTests private GitLabProvider _gitLabProvider; private IGitLabClient _gitLabClient; private IMapper _mapper; +#pragma warning disable NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method private ILogger _logger; +#pragma warning restore NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method private string _token; private string _releaseBaseTag; @@ -48,6 +50,12 @@ public void OneTimeSetUp() _gitLabProvider = new GitLabProvider(_gitLabClient, _mapper, _logger); } + [OneTimeTearDown] + public void OneTimeTearDown() + { + (_logger as IDisposable)?.Dispose(); + } + [Test] [Order(1)] public async Task Should_Get_Milestones() diff --git a/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj b/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj index a7172621..02b3fc05 100644 --- a/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj +++ b/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj @@ -1,32 +1,36 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.IntegrationTests - Integration Test Project for GitReleaseManager - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.IntegrationTests + Integration Test Project for GitReleaseManager + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + all + runtime; build; native; contentfiles; analyzers + + + + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.IntegrationTests/ReleaseNotesBuilderIntegrationTests.cs b/src/GitReleaseManager.IntegrationTests/ReleaseNotesBuilderIntegrationTests.cs index 11706ee3..01676e63 100644 --- a/src/GitReleaseManager.IntegrationTests/ReleaseNotesBuilderIntegrationTests.cs +++ b/src/GitReleaseManager.IntegrationTests/ReleaseNotesBuilderIntegrationTests.cs @@ -20,7 +20,9 @@ namespace GitReleaseManager.IntegrationTests public class ReleaseNotesBuilderIntegrationTests { private IGitHubClient _gitHubClient; +#pragma warning disable NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method private ILogger _logger; +#pragma warning restore NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method private IMapper _mapper; private string _token; @@ -41,6 +43,7 @@ public void Configure() public void TearDown() { Log.CloseAndFlush(); + (_logger as IDisposable)?.Dispose(); } [Test] diff --git a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj index 8d059e56..50f33177 100644 --- a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj +++ b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj @@ -1,31 +1,35 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.Tests - Test Project for GitReleaseManager - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.Tests + Test Project for GitReleaseManager + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + all + runtime; build; native; contentfiles; analyzers + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.Tests/ReleaseNotesBuilderTests.cs b/src/GitReleaseManager.Tests/ReleaseNotesBuilderTests.cs index 43e46526..5e65116f 100644 --- a/src/GitReleaseManager.Tests/ReleaseNotesBuilderTests.cs +++ b/src/GitReleaseManager.Tests/ReleaseNotesBuilderTests.cs @@ -30,7 +30,7 @@ public void NoCommitsNoIssues() public void NoCommitsSomeIssues() { AcceptTest(0, CreateIssue(1, "Bug"), CreateIssue(2, "Feature"), CreateIssue(3, "Improvement")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] @@ -44,7 +44,7 @@ public void SomeCommitsNoIssues() public void SomeCommitsSomeIssues() { AcceptTest(5, CreateIssue(1, "Bug"), CreateIssue(2, "Feature"), CreateIssue(3, "Improvement")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] @@ -58,28 +58,28 @@ public void SingularCommitsNoIssues() public void SingularCommitsSomeIssues() { AcceptTest(1, CreateIssue(1, "Bug"), CreateIssue(2, "Feature"), CreateIssue(3, "Improvement")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] public void SingularCommitsSingularIssues() { AcceptTest(1, CreateIssue(1, "Bug")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] public void NoCommitsSingularIssues() { AcceptTest(0, CreateIssue(1, "Bug")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] public void SomeCommitsSingularIssues() { AcceptTest(5, CreateIssue(1, "Bug")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] @@ -93,14 +93,14 @@ public void SingularCommitsWithHeaderLabelAlias() }); AcceptTest(1, config, CreateIssue(1, "Bug")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] public void SingularCommitsWithMilestoneDescription() { AcceptTest(1, CreateMilestone("2.4.2", "I am some awesome milestone description."), CreateIssue(5, "Feature")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] @@ -114,14 +114,14 @@ public void SomeCommitsWithPluralizedLabelAlias() }); AcceptTest(5, config, CreateIssue(1, "Help Wanted"), CreateIssue(2, "Help Wanted")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] public void SomeCommitsWithoutPluralizedLabelAlias() { AcceptTest(5, CreateIssue(1, "Help Wanted"), CreateIssue(2, "Help Wanted")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] @@ -181,32 +181,32 @@ public void SomeCommitsMultipleWrongIssueLabel() public void CorrectlyExcludeIssues() { AcceptTest(5, CreateIssue(1, "Build"), CreateIssue(2, "Bug")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] public void CorrectlyExcludeIssuesWhenBothIncludeAndExcludeLabelIsSet() { AcceptTest(10, CreateIssue(5, "Improvement", "Build"), CreateIssue(3, "Feature")); - Assert.True(true); + Assert.That(true, Is.True); } private static void AcceptTest(int commits, params Issue[] issues) { AcceptTest(commits, null, null, issues); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } private static void AcceptTest(int commits, Milestone milestone, params Issue[] issues) { AcceptTest(commits, null, milestone, issues); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } private static void AcceptTest(int commits, Config config, params Issue[] issues) { AcceptTest(commits, config, null, issues); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } private static void AcceptTest(int commits, Config config, Milestone milestone, params Issue[] issues) diff --git a/src/GitReleaseManager.Tests/ReleaseNotesExporterTests.cs b/src/GitReleaseManager.Tests/ReleaseNotesExporterTests.cs index 8761d7ef..0b18a68a 100644 --- a/src/GitReleaseManager.Tests/ReleaseNotesExporterTests.cs +++ b/src/GitReleaseManager.Tests/ReleaseNotesExporterTests.cs @@ -22,7 +22,7 @@ public void NoReleases() { var configuration = ConfigurationProvider.Provide(_currentDirectory, _fileSystem); AcceptTest(configuration); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] @@ -30,7 +30,7 @@ public void SingleRelease() { var configuration = ConfigurationProvider.Provide(_currentDirectory, _fileSystem); AcceptTest(configuration, CreateRelease(new DateTime(2015, 3, 12), "0.1.0")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] @@ -40,7 +40,7 @@ public void SingleReleaseExcludeCreatedDateInTitle() configuration.Export.IncludeCreatedDateInTitle = false; AcceptTest(configuration, CreateRelease(new DateTime(2015, 3, 12), "0.1.0")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } [Test] @@ -50,7 +50,7 @@ public void SingleReleaseExcludeRegexRemoval() configuration.Export.PerformRegexRemoval = false; AcceptTest(configuration, CreateRelease(new DateTime(2015, 3, 12), "0.1.0")); - Assert.True(true); // Just to make sonarlint happy + Assert.That(true, Is.True); // Just to make sonarlint happy } private static void AcceptTest(Config configuration, params Release[] releases) diff --git a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj index 9c407a41..62d8edd0 100644 --- a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj +++ b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj @@ -1,54 +1,54 @@ - - - - 8.0 - Exe - GitReleaseManager - - true - net6.0;net7.0 - dotnet-gitreleasemanager - GitReleaseManager.Tool - - GitReleaseManager Tool - GitTools Contributors - https://github.com/GitTools/GitReleaseManager - false - github release notes create export - Tool for creating and exporting releases for software applications from online Version Control Systems - Copyright (c) 2015 - Present - GitTools Contributors - MIT - package_icon.png - https://github.com/GitTools/GitReleaseManager/releases - git - https://github.com/GitTools/GitReleaseManager.git - $(NoWarn);CA1707; - - - - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - - - - - - True - - - + + + + 8.0 + Exe + GitReleaseManager + + true + net6.0;net7.0 + dotnet-gitreleasemanager + GitReleaseManager.Tool + + GitReleaseManager Tool + GitTools Contributors + https://github.com/GitTools/GitReleaseManager + false + github release notes create export + Tool for creating and exporting releases for software applications from online Version Control Systems + Copyright (c) 2015 - Present - GitTools Contributors + MIT + package_icon.png + https://github.com/GitTools/GitReleaseManager/releases + git + https://github.com/GitTools/GitReleaseManager.git + $(NoWarn);CA1707; + + + + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + + + + + + + True + + + \ No newline at end of file diff --git a/tests/integration/tests.cake b/tests/integration/tests.cake index a8989cef..cb268aba 100644 --- a/tests/integration/tests.cake +++ b/tests/integration/tests.cake @@ -50,8 +50,8 @@ Task("Export-Release") }); // Then - Assert.True(FileExists("./output/releasenotes.md")); - Assert.True(FileHashEquals("./expected/releasenotes.md", "./output/releasenotes.md")); + Assert.That(true, FileExists("./output/releasenotes.md")); + Assert.That(true, FileHashEquals("./expected/releasenotes.md", "./output/releasenotes.md")); }); Task("Close-Milestone") From 6c415bd137355500bd5bb99bcef78a96fd7b38a4 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 10 Jul 2024 09:57:12 +0000 Subject: [PATCH 13/15] Bump NUnit from 3.14.0 to 4.1.0 in /src Bumps [NUnit](https://github.com/nunit/nunit) from 3.14.0 to 4.1.0. - [Release notes](https://github.com/nunit/nunit/releases) - [Changelog](https://github.com/nunit/nunit/blob/master/CHANGES.md) - [Commits](https://github.com/nunit/nunit/compare/v3.14.0...4.1.0) --- updated-dependencies: - dependency-name: NUnit dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .../GitReleaseManager.Core.Tests.csproj | 70 +++++++++---------- .../GitReleaseManager.IntegrationTests.csproj | 70 +++++++++---------- .../GitReleaseManager.Tests.csproj | 68 +++++++++--------- 3 files changed, 104 insertions(+), 104 deletions(-) diff --git a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj index 9c04e0c4..92fcbc9b 100644 --- a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj +++ b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj @@ -1,36 +1,36 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.Core.Tests - Test Project for GitReleaseManager.Core - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - all - runtime; build; native; contentfiles; analyzers - - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.Core.Tests + Test Project for GitReleaseManager.Core + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + all + runtime; build; native; contentfiles; analyzers + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj b/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj index 02b3fc05..ff5ce1c9 100644 --- a/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj +++ b/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj @@ -1,36 +1,36 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.IntegrationTests - Integration Test Project for GitReleaseManager - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - all - runtime; build; native; contentfiles; analyzers - - - - - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.IntegrationTests + Integration Test Project for GitReleaseManager + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + all + runtime; build; native; contentfiles; analyzers + + + + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj index 50f33177..e539e268 100644 --- a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj +++ b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj @@ -1,35 +1,35 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.Tests - Test Project for GitReleaseManager - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - all - runtime; build; native; contentfiles; analyzers - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.Tests + Test Project for GitReleaseManager + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + all + runtime; build; native; contentfiles; analyzers + + + + \ No newline at end of file From 1625a520c0dbdf7588b584398a8e947ad615e372 Mon Sep 17 00:00:00 2001 From: Gary Ewan Park Date: Wed, 10 Jul 2024 11:06:51 +0100 Subject: [PATCH 14/15] (test) Remove usage of Assert.AreEqual This no longer exists in NUnit 4.x. --- .../GitReleaseManager.Core.Tests.csproj | 70 +++++++++---------- .../GitReleaseManager.IntegrationTests.csproj | 70 +++++++++---------- .../ConfigurationTests.cs | 14 ++-- .../GitReleaseManager.Tests.csproj | 68 +++++++++--------- 4 files changed, 111 insertions(+), 111 deletions(-) diff --git a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj index 92fcbc9b..c12da586 100644 --- a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj +++ b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj @@ -1,36 +1,36 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.Core.Tests - Test Project for GitReleaseManager.Core - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - all - runtime; build; native; contentfiles; analyzers - - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.Core.Tests + Test Project for GitReleaseManager.Core + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + all + runtime; build; native; contentfiles; analyzers + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj b/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj index ff5ce1c9..ffcbca22 100644 --- a/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj +++ b/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj @@ -1,36 +1,36 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.IntegrationTests - Integration Test Project for GitReleaseManager - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - all - runtime; build; native; contentfiles; analyzers - - - - - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.IntegrationTests + Integration Test Project for GitReleaseManager + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + all + runtime; build; native; contentfiles; analyzers + + + + + + + + \ No newline at end of file diff --git a/src/GitReleaseManager.Tests/ConfigurationTests.cs b/src/GitReleaseManager.Tests/ConfigurationTests.cs index e4112a5c..4ebfc358 100644 --- a/src/GitReleaseManager.Tests/ConfigurationTests.cs +++ b/src/GitReleaseManager.Tests/ConfigurationTests.cs @@ -20,13 +20,13 @@ public void Should_Read_Label_Aliases() var config = ConfigSerializer.Read(stringReader); // Then - Assert.AreEqual(2, config.LabelAliases.Count); - Assert.AreEqual("Bug", config.LabelAliases[0].Name); - Assert.AreEqual("Foo", config.LabelAliases[0].Header); - Assert.AreEqual("Bar", config.LabelAliases[0].Plural); - Assert.AreEqual("Improvement", config.LabelAliases[1].Name); - Assert.AreEqual("Baz", config.LabelAliases[1].Header); - Assert.AreEqual("Qux", config.LabelAliases[1].Plural); + Assert.That(2, Is.EqualTo(config.LabelAliases.Count)); + Assert.That("Bug", Is.EqualTo(config.LabelAliases[0].Name)); + Assert.That("Foo", Is.EqualTo(config.LabelAliases[0].Header)); + Assert.That("Bar", Is.EqualTo(config.LabelAliases[0].Plural)); + Assert.That("Improvement", Is.EqualTo(config.LabelAliases[1].Name)); + Assert.That("Baz", Is.EqualTo(config.LabelAliases[1].Header)); + Assert.That("Qux", Is.EqualTo(config.LabelAliases[1].Plural)); } } diff --git a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj index e539e268..71d2b2da 100644 --- a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj +++ b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj @@ -1,35 +1,35 @@ - - - 8.0 - net6.0;net7.0 - GitReleaseManager.Tests - Test Project for GitReleaseManager - $(NoWarn);CA1707;Serilog004; - - - - - - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - all - runtime; build; native; contentfiles; analyzers - - - - + + + 8.0 + net6.0;net7.0 + GitReleaseManager.Tests + Test Project for GitReleaseManager + $(NoWarn);CA1707;Serilog004; + + + + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + all + runtime; build; native; contentfiles; analyzers + + + + \ No newline at end of file From bff555d612b17f85f7658885555eeee6ac88825a Mon Sep 17 00:00:00 2001 From: jericho Date: Sun, 10 Mar 2024 13:03:20 -0400 Subject: [PATCH 15/15] (#580) Mark the integration test as "inconclusive" Updated the Release Notes Builder Integration Tests as inconclusive, when the GitHub token is not provided. This ensures consistent behavior with other integration tests. --- .../ReleaseNotesBuilderIntegrationTests.cs | 51 ++++++++----------- 1 file changed, 21 insertions(+), 30 deletions(-) diff --git a/src/GitReleaseManager.IntegrationTests/ReleaseNotesBuilderIntegrationTests.cs b/src/GitReleaseManager.IntegrationTests/ReleaseNotesBuilderIntegrationTests.cs index 01676e63..9defd7f7 100644 --- a/src/GitReleaseManager.IntegrationTests/ReleaseNotesBuilderIntegrationTests.cs +++ b/src/GitReleaseManager.IntegrationTests/ReleaseNotesBuilderIntegrationTests.cs @@ -36,6 +36,11 @@ public void Configure() Log.Logger = _logger; _token = Environment.GetEnvironmentVariable("GITTOOLS_GITHUB_TOKEN"); + if (string.IsNullOrWhiteSpace(_token)) + { + Assert.Inconclusive("Unable to locate credentials for accessing GitHub API"); + } + _gitHubClient = new GitHubClient(new ProductHeaderValue("GitReleaseManager")) { Credentials = new Credentials(_token) }; } @@ -50,44 +55,30 @@ public void TearDown() [Explicit] public async Task SingleMilestone() { - if (string.IsNullOrWhiteSpace(_token)) - { - Assert.Inconclusive("Unable to locate credentials for accessing GitHub API"); - } - else - { - var fileSystem = new FileSystem(new CreateSubOptions()); - var currentDirectory = Environment.CurrentDirectory; - var configuration = ConfigurationProvider.Provide(currentDirectory, fileSystem); + var fileSystem = new FileSystem(new CreateSubOptions()); + var currentDirectory = Environment.CurrentDirectory; + var configuration = ConfigurationProvider.Provide(currentDirectory, fileSystem); - var vcsProvider = new GitHubProvider(_gitHubClient, _mapper); - var releaseNotesBuilder = new ReleaseNotesBuilder(vcsProvider, _logger, fileSystem, configuration, new TemplateFactory(fileSystem, configuration, TemplateKind.Create)); - var result = await releaseNotesBuilder.BuildReleaseNotesAsync("Chocolatey", "ChocolateyGUI", "0.12.4", ReleaseTemplates.DEFAULT_NAME).ConfigureAwait(false); - Debug.WriteLine(result); - ClipBoardHelper.SetClipboard(result); - } + var vcsProvider = new GitHubProvider(_gitHubClient, _mapper); + var releaseNotesBuilder = new ReleaseNotesBuilder(vcsProvider, _logger, fileSystem, configuration, new TemplateFactory(fileSystem, configuration, TemplateKind.Create)); + var result = await releaseNotesBuilder.BuildReleaseNotesAsync("Chocolatey", "ChocolateyGUI", "0.12.4", ReleaseTemplates.DEFAULT_NAME).ConfigureAwait(false); + Debug.WriteLine(result); + ClipBoardHelper.SetClipboard(result); } [Test] [Explicit] public async Task SingleMilestone3() { - if (string.IsNullOrWhiteSpace(_token)) - { - Assert.Inconclusive("Unable to locate credentials for accessing GitHub API"); - } - else - { - var fileSystem = new FileSystem(new CreateSubOptions()); - var currentDirectory = Environment.CurrentDirectory; - var configuration = ConfigurationProvider.Provide(currentDirectory, fileSystem); + var fileSystem = new FileSystem(new CreateSubOptions()); + var currentDirectory = Environment.CurrentDirectory; + var configuration = ConfigurationProvider.Provide(currentDirectory, fileSystem); - var vcsProvider = new GitHubProvider(_gitHubClient, _mapper); - var releaseNotesBuilder = new ReleaseNotesBuilder(vcsProvider, _logger, fileSystem, configuration, new TemplateFactory(fileSystem, configuration, TemplateKind.Create)); - var result = await releaseNotesBuilder.BuildReleaseNotesAsync("Chocolatey", "ChocolateyGUI", "0.13.0", ReleaseTemplates.DEFAULT_NAME).ConfigureAwait(false); - Debug.WriteLine(result); - ClipBoardHelper.SetClipboard(result); - } + var vcsProvider = new GitHubProvider(_gitHubClient, _mapper); + var releaseNotesBuilder = new ReleaseNotesBuilder(vcsProvider, _logger, fileSystem, configuration, new TemplateFactory(fileSystem, configuration, TemplateKind.Create)); + var result = await releaseNotesBuilder.BuildReleaseNotesAsync("Chocolatey", "ChocolateyGUI", "0.13.0", ReleaseTemplates.DEFAULT_NAME).ConfigureAwait(false); + Debug.WriteLine(result); + ClipBoardHelper.SetClipboard(result); } [Test]