Merge branch 'main' into claire/rnd-6959-add-support-for-tabs-links-in-gbo

clairechabas · clairechabas · commit 73e57b5b194c · 2025-05-05T11:09:13.000+02:00
* main: Use absolute URLs in sitemap.xml when pointing to sitemap-pages.xml (#3210)
diff --git a/.changeset/real-donkeys-invent.md b/.changeset/real-donkeys-invent.md
@@ -0,0 +1,5 @@
+---
+"gitbook": patch
+---
+
+Fix invalid sitemap.xml generated with relative URLs instead of absolute ones
diff --git a/packages/gitbook/src/routes/sitemap.ts b/packages/gitbook/src/routes/sitemap.ts
@@ -141,7 +141,7 @@ function getUrlsFromSiteSpaces(context: GitBookSiteContext, siteSpaces: SiteSpac
         }
         const url = new URL(siteSpace.urls.published);
         url.pathname = joinPath(url.pathname, 'sitemap-pages.xml');
-        return context.linker.toLinkForContent(url.toString());
+        return context.linker.toAbsoluteURL(context.linker.toLinkForContent(url.toString()));
     }, []);
     return urls.filter(filterOutNullable);
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"gitbook": patch
 +---
++
 +Fix invalid sitemap.xml generated with relative URLs instead of absolute ones
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ function getUrlsFromSiteSpaces(context: GitBookSiteContext, siteSpaces: SiteSpac`
`141`	`141`	`}`
`142`	`142`	`const url = new URL(siteSpace.urls.published);`
`143`	`143`	`url.pathname = joinPath(url.pathname, 'sitemap-pages.xml');`
`144`		`- return context.linker.toLinkForContent(url.toString());`
	`144`	`+ return context.linker.toAbsoluteURL(context.linker.toLinkForContent(url.toString()));`
`145`	`145`	`}, []);`
`146`	`146`	`return urls.filter(filterOutNullable);`
`147`	`147`	`}`