Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Add an option to connect to GitHub anonymously for public repos #56

Closed
wants to merge 1 commit into from

Conversation

ide
Copy link
Contributor

@ide ide commented Apr 5, 2016

Adds a new option called GITHUB_ANONYMOUS to signal that you want to public repositories that don't require any authentication. If you don't set this to true, Nuts will continue to throw an error if you don't provide authentication credentials.

This uses the getenv package, which handles env var values like "true" and "1" as bash would.

Adds a new option called `GITHUB_ANONYMOUS` to signal that you want to public repositories that don't require any authentication. If you don't set this to true, Nuts will continue to throw an error if you don't provide authentication credentials.

This uses the `getenv` package, which handles env var values like "true" and "1" as bash would.
@SamyPesse
Copy link
Member

Sorry for the delay.

Why not considering it's anonymous when neither username or password is set and proxyAssets is a true? (Throw an error only when username without password is set).

@ide
Copy link
Contributor Author

ide commented Apr 18, 2016

That could work too. I added the "anonymous" flag to help people who are setting up Nuts with a private Github repo. Currently (before this PR) they would see "GitHub backend require "username" and "token" options" if they didn't configure Nuts correctly. I thought this was helpful so I kept a similar error message unless the user actually wanted Nuts to be anonymous.

@SamyPesse SamyPesse mentioned this pull request Aug 24, 2016
@ide ide closed this Dec 3, 2019
@biw biw mentioned this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants