Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change UI so users can issue attestation as multiple attester orgs #168

Open
divine-comedian opened this issue Sep 5, 2024 · 6 comments
Assignees
Labels
SC Integration Integration of DeVouch Smart Contract features

Comments

@divine-comedian
Copy link
Contributor

in #167 users will be able to issue multiple attestations in one transaction using a new contract. This will allow users to issue a vouch or flag as one or more attester orgs that they belong to, each one becoming a separate attestation.

the UX of vouching or flaggin will need a simple change of the attester orgs selection component to be multi select instead of single select. some slight copy changes will be required on the same modal.

Image

even if the user issues an attestation at once as multiple attester orgs they will still be treated separately on the table of attestation data for users and project. We will not need any UI changes in how we handle editing and deleting a particular attestation

@divine-comedian divine-comedian moved this to BLOCKED in DeVouch Sep 5, 2024
@divine-comedian divine-comedian moved this from BLOCKED to Todo in DeVouch Oct 11, 2024
@divine-comedian
Copy link
Contributor Author

@Tosinolawale - can you mock this one up, very small change I think UX wise

  • users can select multiple groups to attest as if they are eligible members.
  • one comment is issued even if they are attesting as multiple groups
  • need to handle minting gitcoin passport feature

@divine-comedian divine-comedian moved this from Todo to Design in DeVouch Oct 11, 2024
@divine-comedian divine-comedian added the SC Integration Integration of DeVouch Smart Contract features label Oct 11, 2024
@Tosinolawale
Copy link

Quick question @divine-comedian currently the Minting feature is only for qualified users with no other attestation groups. That still holds right? With this feature users still won't be able to select another attester group simultaneously with Gitcoin Passport minting

@divine-comedian
Copy link
Contributor Author

Quick question @divine-comedian currently the Minting feature is only for qualified users with no other attestation groups. That still holds right? With this feature users still won't be able to select another attester group simultaneously with Gitcoin Passport minting

That would definitely make the UX easier to implement - I'm in favour of not allowing users to simultaenously select gitcoin passport if they don't already have a minted passport

@Tosinolawale
Copy link

Quick question @divine-comedian currently the Minting feature is only for qualified users with no other attestation groups. That still holds right? With this feature users still won't be able to select another attester group simultaneously with Gitcoin Passport minting

That would definitely make the UX easier to implement - I'm in favour of not allowing users to simultaenously select gitcoin passport if they don't already have a minted passport

Me too. So yeah, it is ready for development.

@divine-comedian divine-comedian moved this from Design to Todo in DeVouch Oct 25, 2024
@divine-comedian
Copy link
Contributor Author

@mateodaza for you to take a look at once smart contract is deployed on testnet and BE is integrated and working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SC Integration Integration of DeVouch Smart Contract features
Projects
Status: Todo
Development

No branches or pull requests

4 participants