-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QF of Stellar | QF toast msg in success donation page. #4753
Comments
I edited the title of this issue as well @HrithikSampson |
@maryjaf please also take a look here. |
Hi @maryjaf , https://giveth-dapps-v2-git-add-givbacks-and-qf-badges-ed2d3d-givethio.vercel.app/ |
The GIVback and QF box is shown correctly in success donation page but there are some problems 1- I couldn't scroll up in this page for both one time and stellar donation Screen.Recording.2024-09-22.at.1.48.52.PM.mov2- when the donation amount is lower than minimum amount for matching but my user is eligible, this box is still shown( I've reported this problem on another issue and @laurenluz knows about it) |
@maryjaf , I have tried to fix the first point. @laurenluz , I think #4539 is the issue described in the second point. I am not sure what to do in this issue. |
@HrithikSampson just make sure the same scenario in #4539 is correct in the success donation with Stellar, Please note that the success page in Stellar is a little bit different in the below section, having more reference links. |
|
I think this is fixed now |
cc: @maryjaf |
The problem related to scroll has been fixed. but the problem related showing QF and GIVback box in sucess donation page hasn't been fixed @HrithikSampson and this donation https://stellar.expert/explorer/public/tx/e093cc3081bd9d9e053e7c5ed9863048d85c455394131401c2dd95313e3f1929 is not QF and GIVback eligible but i see both boxs in sucess donation page |
@maryjaf ,I have tried to fix it |
I haven't seen any changes on this branch about these scenarios Have you tested it and it worked on this branch? @HrithikSampson |
This problem has been fixed, thanks @HrithikSampson |
As a user, I want to see the estimated matching amount after I donate.
Link to design: https://www.figma.com/design/qXxAEsN3jePyRqBcHR9Ihq/Donation?node-id=6438-12801&t=YenqWHsRwDdfAlvL-4
Please note that if the donation was giveback eligible, we have to show the giveback purple box as well.
The text was updated successfully, but these errors were encountered: