Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QF of Stellar | QF toast msg in success donation page. #4753

Closed
MoeNick opened this issue Sep 18, 2024 · 13 comments
Closed

QF of Stellar | QF toast msg in success donation page. #4753

MoeNick opened this issue Sep 18, 2024 · 13 comments
Assignees

Comments

@MoeNick
Copy link
Member

MoeNick commented Sep 18, 2024

As a user, I want to see the estimated matching amount after I donate.
image

Link to design: https://www.figma.com/design/qXxAEsN3jePyRqBcHR9Ihq/Donation?node-id=6438-12801&t=YenqWHsRwDdfAlvL-4

Please note that if the donation was giveback eligible, we have to show the giveback purple box as well.

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Sep 18, 2024
@MoeNick MoeNick changed the title QF of Stellar | Estimated matching on the project card on the amount page QF of Stellar | QF toast msg in success donation page. Sep 19, 2024
@MoeNick
Copy link
Member Author

MoeNick commented Sep 19, 2024

I edited the title of this issue as well @HrithikSampson
Sorry for the typo, it's more clear now

@HrithikSampson HrithikSampson moved this from New Issues to In Progress in All-Devs Sep 20, 2024
@MoeNick
Copy link
Member Author

MoeNick commented Sep 22, 2024

@maryjaf please also take a look here.

@HrithikSampson HrithikSampson moved this from In Progress to QA in All-Devs Sep 22, 2024
@HrithikSampson
Copy link
Collaborator

Hi @maryjaf , https://giveth-dapps-v2-git-add-givbacks-and-qf-badges-ed2d3d-givethio.vercel.app/
I have done this change in the same link

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 22, 2024

The GIVback and QF box is shown correctly in success donation page but there are some problems
image

1- I couldn't scroll up in this page for both one time and stellar donation

Screen.Recording.2024-09-22.at.1.48.52.PM.mov

2- when the donation amount is lower than minimum amount for matching but my user is eligible, this box is still shown( I've reported this problem on another issue and @laurenluz knows about it)
image

@HrithikSampson
Copy link
Collaborator

@maryjaf , I have tried to fix the first point.

@laurenluz , I think #4539 is the issue described in the second point. I am not sure what to do in this issue.

@MoeNick
Copy link
Member Author

MoeNick commented Sep 22, 2024

@HrithikSampson just make sure the same scenario in #4539 is correct in the success donation with Stellar, Please note that the success page in Stellar is a little bit different in the below section, having more reference links.

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 22, 2024

  • 3- I enter an amount that is lower than minimum of QF matching and GIVback but I see the givback and QF eligible box in success donation page @HrithikSampson
    If I remember correctly it worked as expected before
Screenshot 2024-09-22 at 5 14 09 PM Screenshot 2024-09-22 at 5 12 32 PM

@HrithikSampson
Copy link
Collaborator

HrithikSampson commented Sep 22, 2024

  • 3- I enter an amount that is lower than minimum of QF matching and GIVback but I see the givback and QF eligible box in success donation page @HrithikSampson
    If I remember correctly it worked as expected before

Screenshot 2024-09-22 at 5 14 09 PM Screenshot 2024-09-22 at 5 12 32 PM

I think this is fixed now

@HrithikSampson
Copy link
Collaborator

  • 3- I enter an amount that is lower than minimum of QF matching and GIVback but I see the givback and QF eligible box in success donation page @HrithikSampson
    If I remember correctly it worked as expected before

Screenshot 2024-09-22 at 5 14 09 PM Screenshot 2024-09-22 at 5 12 32 PM

@maryjaf ,I think this is fixed now

cc: @maryjaf

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 22, 2024

  • 3- I enter an amount that is lower than minimum of QF matching and GIVback but I see the givback and QF eligible box in success donation page @HrithikSampson
    If I remember correctly it worked as expected before

Screenshot 2024-09-22 at 5 14 09 PM Screenshot 2024-09-22 at 5 12 32 PM

@maryjaf ,I think this is fixed now

cc: @maryjaf

The problem related to scroll has been fixed. but the problem related showing QF and GIVback box in sucess donation page hasn't been fixed @HrithikSampson
for example this donation https://stellar.expert/explorer/public/tx/cda9a59f977f0eaa9349f81b9f9ba773c4385723320d10bc6e0fc43b60168494 isn't a givbacl eligible transaction but I see below pic

image

and this donation https://stellar.expert/explorer/public/tx/e093cc3081bd9d9e053e7c5ed9863048d85c455394131401c2dd95313e3f1929 is not QF and GIVback eligible but i see both boxs in sucess donation page

image

@HrithikSampson
Copy link
Collaborator

  • 3- I enter an amount that is lower than minimum of QF matching and GIVback but I see the givback and QF eligible box in success donation page @HrithikSampson
    If I remember correctly it worked as expected before

Screenshot 2024-09-22 at 5 14 09 PM Screenshot 2024-09-22 at 5 12 32 PM

@maryjaf ,I think this is fixed now

cc: @maryjaf

The problem related to scroll has been fixed. but the problem related showing QF and GIVback box in sucess donation page hasn't been fixed @HrithikSampson for example this donation https://stellar.expert/explorer/public/tx/cda9a59f977f0eaa9349f81b9f9ba773c4385723320d10bc6e0fc43b60168494 isn't a givbacl eligible transaction but I see below pic

image

and this donation https://stellar.expert/explorer/public/tx/e093cc3081bd9d9e053e7c5ed9863048d85c455394131401c2dd95313e3f1929 is not QF and GIVback eligible but i see both boxs in sucess donation page

image

@maryjaf ,I have tried to fix it

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 23, 2024

and this donation https://stellar.expert/explorer/public/tx/e093cc3081bd9d9e053e7c5ed9863048d85c455394131401c2dd95313e3f1929 is not QF and GIVback eligible but i see both boxs in sucess donation page

I haven't seen any changes on this branch about these scenarios
https://giveth-dapps-v2-git-add-givbacks-and-qf-badges-ed2d3d-givethio.vercel.app/donate/test-stellar?chain=stellar&draft_donation=1458

Have you tested it and it worked on this branch? @HrithikSampson

image

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 23, 2024

This problem has been fixed, thanks @HrithikSampson

@maryjaf maryjaf moved this from QA to Done in All-Devs Sep 23, 2024
@divine-comedian divine-comedian closed this as completed by moving to Merged to Production in All-Devs Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in All-Devs Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants