Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "is the donation anonymous" to GIVbacks API export #4757

Closed
laurenluz opened this issue Sep 19, 2024 · 2 comments
Closed

Add "is the donation anonymous" to GIVbacks API export #4757

laurenluz opened this issue Sep 19, 2024 · 2 comments
Assignees

Comments

@laurenluz
Copy link
Member

I want an extra column in the data that Ashley grabs from the givbacks API each round that shows whether the donor selected the "donate anonymously" button, or not.

image

cc @WhyldWanderer

@mohammadranjbarz
Copy link
Contributor

@WhyldWanderer @maryjaf It's on staging and is ready for the test

@mohammadranjbarz mohammadranjbarz moved this from In Progress to QA in All-Devs Sep 22, 2024
@maryjaf
Copy link
Collaborator

maryjaf commented Sep 26, 2024

I made an anonymous donation and I see the below response in givback api,
this field is added in response :
"anonymous": true,
[
{
"amount": 5,
"currency": "GIV",
"createdAt": "2024-09-26-06:25:10",
"valueUsd": 5,
"anonymous": true,
"bottomRankInRound": 35,
"givbacksRound": 51089,
"projectRank": 22,
"givbackFactor": 0.61470586,
"valueUsdAfterGivbackFactor": 3.0735293,
"giverAddress": "0xa1179f64638adb613ddaac32d918eb6beb824104",
"txHash": "0x8a10dc5e0846d1380f5bb43a2ea6a54ac51f6b98931095687d7178907096578b",
"network": "optimism-sepolia",
"source": "giveth.io",
"giverName": "mary jafarimehr",
"giverEmail": null,
"projectLink": "https://giveth.io/project/mejan",
"isReferrerGivbackEligible": false,
"referrerWallet": null
},


if the donation isn't an anonymous donation, this field is set false as expected in response
"anonymous": false

@maryjaf maryjaf moved this from QA to Done in All-Devs Sep 26, 2024
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Oct 4, 2024
@divine-comedian divine-comedian closed this as completed by moving to Merged to Production in All-Devs Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in All-Devs Oct 4, 2024
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged to Production
Development

No branches or pull requests

4 participants