Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new wallets to Documentation #204

Open
franculio opened this issue Oct 27, 2023 · 5 comments
Open

Add new wallets to Documentation #204

franculio opened this issue Oct 27, 2023 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@franculio
Copy link
Contributor

Going through the documentation I noticed that we could update the new wallets added in the last version of the Dapp released.

Private Zenhub Image

@divine-comedian could you confirm which wallets need to be added?

@franculio franculio added the documentation Improvements or additions to documentation label Oct 27, 2023
@franculio franculio self-assigned this Oct 27, 2023
@divine-comedian
Copy link
Contributor

divine-comedian commented Oct 27, 2023

Yeah well I think this will also be changing soon the UX for connecting wallets
Giveth/giveth-dapps-v2#3370

and soon even more when the multisig login feature goes live in the next few weeks

and EVEN MORE will also change again when we add Solana to the dapp perhaps in about a month and a half

Big changes CURRENTLY are that we removed support for torus wallets (and users should import their private keys to a new compatible wallet like metamask) and we added in mobile support for MetaMask on mobile browsers such as safari or chrome

Right now the dapp is optimized for use with Metamask but you still should be able to connect with any browser desktop extension, mobile wallet apps are a bit more tricky

@oyealmond
Copy link

should we update this now @divine-comedian?
cc @franculio

@oyealmond
Copy link

Hello @divine-comedian, I will move this issue to Notion. Is there something else we should consider to update documentation about wallets? Or this is it.

@ahmadabugosh
Copy link

@oyealmond I would add

  1. Now that Solana is live, we should make it clear that those are counted as two different wallets atm (and they aren't connected)
  2. Also mention the new chains we recently added like Polygon, Arbitrum etc.

@divine-comedian divine-comedian transferred this issue from Giveth/giveth-planning Mar 10, 2024
@divine-comedian
Copy link
Contributor

divine-comedian commented Mar 10, 2024

I moved this to the giveth-docs repo - good point @ahmadabugosh we don't have any docs for connecting with Solana at all.

You can keep this in Notion and reference this github issue @oyealmond

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants